Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fallback extension to local data always when extension is disabled #8720

Closed
cezaraugusto opened this issue May 5, 2017 · 0 comments
Closed

Fallback extension to local data always when extension is disabled #8720

cezaraugusto opened this issue May 5, 2017 · 0 comments
Assignees
@cezaraugusto
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 5, 2017 •
edited by luixxiul
Loading

Test plan

#8721 (comment)

@bbondy reported an issue regarding LastPass where the image is broken and description is showing as __MSG__:

screenshot 2017-05-05 08 00 33

Issue happens because once enabled for the first time, extension data is got from the manifest, and if you disable chrome-extension URL is no longer valid, and data is lost.

To fix that we should fallback to local data always when the extension is disabled.
@cezaraugusto cezaraugusto added this to the 0.15.3 milestone May 5, 2017
@cezaraugusto cezaraugusto self-assigned this May 5, 2017
cezaraugusto added a commit that referenced this issue May 5, 2017
@cezaraugusto
fallback to local data when extension is disabled
ab727cb 
- Auditors: @bbondy
- Fix #8720
@cezaraugusto cezaraugusto mentioned this issue May 5, 2017
Merged
This was referenced May 5, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @cezaraugusto @srirambv