Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add extension inspectors #8012

Closed
danfinlay opened this issue Mar 31, 2017 · 4 comments
Closed

Add extension inspectors #8012

danfinlay opened this issue Mar 31, 2017 · 4 comments

Comments

@danfinlay
Copy link

danfinlay commented Mar 31, 2017

Test plan

8110f82


  • Did you search for similar issues before submitting this one?

yes

  • Describe the issue you encountered:

As an extension developer, I often inspect my extension in one of two major contexts:

  • When clicking on the extension icon in the menu, I right-click that interface and select Inspect Element to get a Chrome inspector for that view.
  • In the extensions list, I am used to having a background console link, to open a full Chrome inspector for the extension background process.

Neither of these inspectors seem to exist in Brave today.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

Mac OS 10.12.4

  • Brave Version (revision SHA):

Brave 0.14.0
rev 215cba3

  • Steps to reproduce:
  1. Click on the extension icon in the menu,

  2. Right-click that interface.

  3. Notice no contextual menu, even though this is a web view.

  4. Visit about:extensions.

  5. Notice there are no links to open background inspectors.

  • Actual result:

There seem to be no ways to inspect extensions and their behaviors.

  • Expected result:

Extension developers need dev tools to debug their extensions.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

  • Is this an issue in the currently released version?

I believe so.

  • Can this issue be consistently reproduced?

Yes

  • Extra QA steps:
    1.
    2.
    3.
@jonathansampson
Copy link
Collaborator

jonathansampson commented May 4, 2017

@FlySwatter I believe we have what you're seeking, only it's not as easy to get to (not yet; I have a PR in the works to reduce friction).

  1. Go to about:extensions and get the extension ID
  2. Navigate to the background page via chrome-extension:///backroundpage.html.

If no explicit background page is provided, the file will be generated_background_page.html, IIRC.

This should open up an instance of the developer tools, pointing to the background page.

Please confirm whether or not this is what you were seeking.

@danfinlay
Copy link
Author

Oh great, thanks for the tip! I'll continue debugging this soon!

@jonathansampson
Copy link
Collaborator

@FlySwatter Please confirm whether or not this is what you needed. We'll be making it easier to reach in future builds :)

@danfinlay
Copy link
Author

Will verify soon, still 1 day left in the Internet Identity workshop (you'd probably fit in nicely here...)

@evq evq mentioned this issue Jul 27, 2017
8 tasks
evq added a commit that referenced this issue Jul 30, 2017
evq added a commit that referenced this issue Jul 31, 2017
Fixes #8012

Auditors: @luixxiul

Test Plan:

Ensure extension links work when presented and are not present for
disabled / invalid:
1. Go to `about:extensions`
2. Click on the pdf viewer inspect view and confirm dev tools are launched
3. In another tab go to `about:preferences#extensions` and enable 1password
4. Click on the 1password inspect view and confirm dev tools are launched
5. In another tab go to `about:preferences#extensions` and enable bitwarden
6. Confirm the dev tools pane for 1password has closed
7. Confirm that `about:extensions` no longer shows inspect views for 1password
8. Click on the bitwarden inspect view and confirm dev tools are launched
9. Confirm that `about:extensions` has no inspect views for torrent viewer

Ensure the following appear as orange anchor links:
1. Payment FAQ on `about:preferences#payment`
2. Adobe and wiki `about:preferences#plugins`
3. Release notes and revision on `about:brave`
4. Inspect pages on `about:extensions`
5. Manage passwords on `about:preferences#security`
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Jul 31, 2017
evq added a commit that referenced this issue Aug 9, 2017
Fixes #8012

Auditors: @luixxiul

Test Plan:

Ensure extension links work when presented and are not present for
disabled / invalid:
1. Go to `about:extensions`
2. Click on the pdf viewer inspect view and confirm dev tools are launched
3. In another tab go to `about:preferences#extensions` and enable 1password
4. Click on the 1password inspect view and confirm dev tools are launched
5. In another tab go to `about:preferences#extensions` and enable bitwarden
6. Confirm the dev tools pane for 1password has closed
7. Confirm that `about:extensions` no longer shows inspect views for 1password
8. Click on the bitwarden inspect view and confirm dev tools are launched
9. Confirm that `about:extensions` has no inspect views for torrent viewer

Ensure the following appear as orange anchor links:
1. Payment FAQ on `about:preferences#payment`
2. Adobe and wiki `about:preferences#plugins`
3. Release notes and revision on `about:brave`
4. Inspect pages on `about:extensions`
5. Manage passwords on `about:preferences#security`
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.