Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hit boxes on allow scripts are too small, create unintended modal closure when missed. #7430

Closed
alexwykoff opened this issue Mar 1, 2017 · 2 comments · Fixed by #7434
Closed

Hit boxes on allow scripts are too small, create unintended modal closure when missed. #7430

alexwykoff opened this issue Mar 1, 2017 · 2 comments · Fixed by #7434
Assignees
@diracdeltas
Labels
accessibility design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.5

Comments

@alexwykoff
Copy link
Contributor

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When attempting to click on the checkboxes to allow scripts, I missed by what felt like a pixel. The modal closed.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version (revision SHA):
    0.13.5 (0dc505a)

  • Steps to reproduce:

    1. Block scripts for a site (or globally)
    2. Visit a site with scripts
    3. Open the script control modal on the urlbar
    4. Attempt to click on checkboxes quickly

  • Actual result:
    If you miss the checkboxes by a minor amount, the modal closes and the user has to start over.

  • Expected result:
    The checkboxes should have some forgiveness to them and be contained in a margin of space which does not register clicks.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No, this is a new feature.

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
    add noScriptInfo checkboxes to allow scripts by origin #7272
@alexwykoff alexwykoff added accessibility design A design change, especially one which needs input from the design team. labels Mar 1, 2017
@alexwykoff alexwykoff added this to the 0.13.5 milestone Mar 1, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 1, 2017 •
edited
Loading

@alexwykoff I think that we shouldn't close dialog if you click inside the dialog. We should only close it if:

  • you click on either button or
  • you click outside of the box

cc @bradleyrichter

@diracdeltas
Copy link
Member

i'm working on that @NejcZdovc

diracdeltas added a commit that referenced this issue Mar 1, 2017
@diracdeltas
noscript info dialog improvements
3f831c6 
* make it easier to click the checkboxes. fix #7430.
* do not close the dialog unless clicking outside or on a button.
* make the dialog the same whether noscript is globally enabled or not.
* if no checkboxes are checked, clicking the button should be a no-op.
@diracdeltas diracdeltas mentioned this issue Mar 1, 2017
Merged
4 tasks
This was referenced Mar 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
accessibility design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.5
Development

Successfully merging a pull request may close this issue.

noscript info dialog improvements brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @NejcZdovc @srirambv