Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed display of Contribution Statement #7416

Closed
keverets opened this issue Feb 28, 2017 · 5 comments · Fixed by brave/muon#167
Closed

Fixed display of Contribution Statement #7416

keverets opened this issue Feb 28, 2017 · 5 comments · Fixed by brave/muon#167
Assignees
@darkdh
Labels
bug feature/rewards QA/checked-macOS QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@keverets
Copy link

keverets commented Feb 28, 2017 •
edited by bsclifton
Loading

Test plan

  1. Have a contribution history (or create one if needed in dev, via npm run add-simulated-payment-history and then copy your ledger files over your existing ledger files)
  2. Open preferences and go to the payments tab
  3. Click the clock icon in the top right
  4. There should be several statements in the list. Click one
  5. The statement should show up (and stay on the screen)
  6. A few moments later, the statement should try to print itself

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes, none found.

  • Describe the issue you encountered:
    Preferences -> View Payment History... -> Receipt Link (to Brave_Payments_2017-02-21.pdf)
    Opens briefly in a new tab then closes immediately.
    Repeated trials will let me get a sense of what's in it (it does appear to be a correct rendering of the payments), but there's no way to capture it before the tab closes less than a second later. The link to the PDF is a "chrome-extension://" link so there appears to be no easy way to extract the info.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Ubuntu 14.04.5

  • Brave Version (revision SHA):
    0.13.4-1
    About -> Brave shows:
    Brave 0.13.4
    rev 71d8ffc
    Muon 2.56.4
    libchromiumcontent 56.0.2924.87
    V8 5.6.326.50
    Node.js 7.4.0
    Update Channel dev
    os.platform linux
    os.release 4.5.3-040503-generic
    os.arch x64

  • Steps to reproduce:

    1. Make bitcoin contribution
    2. Visit sites
    3. After a month, check Preferences -> View Payment History... -> Receipt Link

  • Actual result:
    Statement appears in a new tab for less than 1 second then closes.

  • Expected result:
    Statement should stay visible in the tab.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Unknown. Not going to throw more money at this until it's fixed.

  • Is this an issue in the currently released version?
    Yes.

  • Can this issue be consistently reproduced?
    Yes.
@bsclifton
Copy link
Member

I'm also seeing this too, with 0.13.4 on macOS ☹️

@bsclifton bsclifton added this to the 0.13.6 milestone Feb 28, 2017
@cezaraugusto cezaraugusto mentioned this issue Mar 1, 2017
Merged
@willy-b
Copy link
Contributor

willy-b commented Mar 1, 2017

The webContents.printToPDF method in Muon which this depends on seems to have broken again (see #6450).

@bsclifton
Copy link
Member

Not fixed by brave/muon#166 ☹️

@darkdh darkdh self-assigned this Mar 2, 2017
@diracdeltas
Copy link
Member

+1 for fixing this

darkdh added a commit to brave/muon that referenced this issue Mar 4, 2017
@darkdh
Fix printToPDF on chromium56
0ab197d 
fix brave/browser-laptop#7416

Auditors: @bridiver, @bbondy, @bsclifton

1. Use RenderFrameHost instead of RenderViewHost
(https://chromium.googlesource.com/chromium/src.git/+/cb959ce66a9a89b6f100795bb33292439a7ed7de)
2. Add scaleFactor for check in https://chromium.googlesource.com/chromium/src.git/+/56.0.2924.87/printing/print_settings_conversion.cc#187
(https://chromium.googlesource.com/chromium/src.git/+/769ffdf779d83399a6f219e2637c6469ab94da0e
3. Add correct HostID & RountingID for CreatePrinterQuery
(https://chromium.googlesource.com/chromium/src.git/+/56.0.2924.87/chrome/browser/printing/printing_message_filter.cc#267)
@darkdh darkdh mentioned this issue Mar 4, 2017
Merged
@NejcZdovc NejcZdovc mentioned this issue Mar 8, 2017
Closed
This was referenced Mar 10, 2017
Closed
Closed
Merged
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
This was referenced Mar 29, 2017
Closed
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Step 6 fails on Windows 10 x64
image

@alexwykoff alexwykoff changed the title Can't view "Contribution Statement" Fixed display of Contribution Statement Mar 30, 2017
@darkdh darkdh mentioned this issue Apr 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug feature/rewards QA/checked-macOS QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Fix printToPDF on chromium56 brave/muon
7 participants
@keverets @diracdeltas @alexwykoff @bsclifton @willy-b @darkdh @srirambv