Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed style on ledger settings UI area to match 1.0 features/changes #7348

Closed
bradleyrichter opened this issue Feb 21, 2017 · 5 comments · Fixed by #7532
Closed

Fixed style on ledger settings UI area to match 1.0 features/changes #7348

bradleyrichter opened this issue Feb 21, 2017 · 5 comments · Fixed by #7532

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Feb 21, 2017

Test plan

UI should match this mock up (see detailed notes below)

image

item 1: convert advanced settings text button into an icon button. Convert Payments History link into icon button in same location.

item 2: move Add funds... button to column 3.

Item 3: Break out and add "Last contribution" string to column 1, row 2.

Item 4: Break out and add "Next contribution" string to column 2, row 2.

Item 5: Add style for non-editable edit-box form element.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 21, 2017

@bradleyrichter please add all icons that are needed for this issue

  • settings
  • history
  • pin
  • delete
  • twitter

@luixxiul
Copy link
Contributor

@bradleyrichter Should the color of the icon in the left column be green?

@bradleyrichter
Copy link
Contributor Author

@luixxiul Currently the SVGs are all orange for selected state. Do you think we should do unique colors? (the green was an experiment that stayed in the mockup...)

@luixxiul
Copy link
Contributor

I'm not quite sure but for me all orange looks too much monotone. Still if we would do unique colors, maybe theme colors needs picking up for each item (general/tab/search/...) and I think we don't want to do that.

@NejcZdovc NejcZdovc self-assigned this Feb 28, 2017
@NejcZdovc
Copy link
Contributor

SVG icons

ledger_icons.zip

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 8, 2017
Resolves brave#7348

Auditors: @bsclifton @bradleyrichter

Test Plan:
- layout should be the same as is on mock in issue brave#7348
@NejcZdovc NejcZdovc mentioned this issue Mar 8, 2017
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 8, 2017
Resolves brave#7348

Auditors: @bsclifton @bradleyrichter

Test Plan:
- layout should be the same as is on mock in issue brave#7348
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 11, 2017
Resolves brave#7348

Auditors: @bsclifton @bradleyrichter

Test Plan:
- layout should be the same as is on mock in issue brave#7348
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
Resolves brave#7348

Auditors: @bsclifton @bradleyrichter

Test Plan:
- layout should be the same as is on mock in issue brave#7348
bsclifton added a commit that referenced this issue Mar 13, 2017
@alexwykoff alexwykoff changed the title update ledger settings UI area to match 1.0 features/changes Fixed style on ledger settings UI area to match 1.0 features/changes Mar 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.