-
Notifications
You must be signed in to change notification settings - Fork 974
when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled (follow-up of #6033) #6863
Comments
I can't reproduce this on MacOs on the latest master commit 96eb071 |
Do you think the issue was fixed or does something behave differently between Windows and macOS? |
@luixxiul it works for me too? Let me try the latest RC on Windows |
Notice: it will only cause the move animation if you drag in that half of the tab. This is expected. So in order to move the first tab, you have to move past the middle of the tab |
How about after pinning a couple of tabs? |
@luixxiul that looks great too (on both Windows and macOS; here's Windows) |
@bsclifton @NejcZdovc can you drop the tab exactly where 🚫 is displayed? |
We don't need to display the 🚫 icon since the ability to drop is indicated by the tab movement. |
but actually I cannot drop the tab there and that's exactly the issue I think which should be fixed. |
I don't have a 🚫 icon either, do you think you can find out why you have it @luixxiul so that others can reproduce better? Thanks. Moving to 0.13.2 for now. |
I think maybe this is specific to Windows. 🚫 appears several times in the gif by @bsclifton above as well: #6863 (comment) The issue here is that when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled, while the tab animation indicates as if you could drop it there. |
@NejcZdovc would you mind checking the issue? |
Will check it out |
Closing as a duplicate of #6242 |
It seems that on the latest RC build the issue has been solved; I don't see 🚫 anymore. |
Describe the issue you encountered:
#6033 (comment)
Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit
Brave Version (revision SHA): a37f260
Steps to reproduce:
Actual result: Tab C cannot be dropped there
Expected result: Tac C should be dropped there
The text was updated successfully, but these errors were encountered: