Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled (follow-up of #6033) #6863

Closed
luixxiul opened this issue Jan 26, 2017 · 16 comments
Assignees

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jan 26, 2017

Describe the issue you encountered:
#6033 (comment)

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): a37f260

  • Steps to reproduce:

dnd

  1. Open a tab (Tab A)
  2. Open another tab (Tab B)
  3. Open another tab (Tab C)
  4. Grab Tab C
  5. Try to drop Tab C between Tab A & B, ie exactly where 🚫 is displayed

Actual result: Tab C cannot be dropped there

Expected result: Tac C should be dropped there

@NejcZdovc
Copy link
Contributor

I can't reproduce this on MacOs on the latest master commit 96eb071

@luixxiul
Copy link
Contributor Author

Do you think the issue was fixed or does something behave differently between Windows and macOS?

@bsclifton
Copy link
Member

@luixxiul it works for me too? Let me try the latest RC on Windows

@bsclifton
Copy link
Member

bsclifton commented Jan 26, 2017

LGTM on Windows 10 😄

drag

@bsclifton
Copy link
Member

Notice: it will only cause the move animation if you drag in that half of the tab. This is expected. So in order to move the first tab, you have to move past the middle of the tab

@luixxiul
Copy link
Contributor Author

How about after pinning a couple of tabs?

@bsclifton
Copy link
Member

@luixxiul that looks great too (on both Windows and macOS; here's Windows)

drag2

@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 26, 2017

@bsclifton @NejcZdovc can you drop the tab exactly where 🚫 is displayed?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jan 27, 2017
@bradleyrichter
Copy link
Contributor

We don't need to display the 🚫 icon since the ability to drop is indicated by the tab movement.

@luixxiul
Copy link
Contributor Author

but actually I cannot drop the tab there and that's exactly the issue I think which should be fixed.

@bbondy
Copy link
Member

bbondy commented Jan 28, 2017

I don't have a 🚫 icon either, do you think you can find out why you have it @luixxiul so that others can reproduce better? Thanks. Moving to 0.13.2 for now.

@bbondy bbondy modified the milestones: 0.13.2, 0.13.1 Jan 28, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 5, 2017

I think maybe this is specific to Windows. 🚫 appears several times in the gif by @bsclifton above as well: #6863 (comment)

The issue here is that when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled, while the tab animation indicates as if you could drop it there.

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Feb 25, 2017
@luixxiul
Copy link
Contributor Author

@NejcZdovc would you mind checking the issue?

@NejcZdovc
Copy link
Contributor

Will check it out

@luixxiul luixxiul changed the title Dnd for tabs (follow-up of #6033) when you drag the tab and drop it exactly where 🚫 is displayed, the drop is canceled (follow-up of #6033) Apr 14, 2017
@bsclifton
Copy link
Member

Closing as a duplicate of #6242

@bsclifton bsclifton added the duplicate Issue has already been reported label Apr 19, 2017
@luixxiul
Copy link
Contributor Author

It seems that on the latest RC build the issue has been solved; I don't see 🚫 anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants