Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension: Pinterest Save Button #6366

Closed
6 of 23 tasks
jonathansampson opened this issue Dec 21, 2016 · 6 comments
Closed
6 of 23 tasks

Extension: Pinterest Save Button #6366

jonathansampson opened this issue Dec 21, 2016 · 6 comments
Assignees
@jonathansampson @alexwykoff
Labels
bug feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. project-tracking wontfix

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Dec 21, 2016 •
edited
Loading

Extension: Pinterest Save Button
Background Page: Coming soon

Needed APIs:

chrome.browserAction

chrome.contextMenus

chrome.cookies

chrome.extension

chrome.i18n

chrome.notifications

chrome.runtime

chrome.storage

chrome.tabs
@jonathansampson jonathansampson changed the title Pinterest: chrome.cookies.set not supported Extension: Pinterest Save Button Apr 19, 2017
@jonathansampson jonathansampson mentioned this issue Apr 19, 2017
Closed
@kentbrew
Copy link

Happy to help with this; I'm the developer of the Pinterest extension for Chrome.

@jonathansampson
Copy link
Collaborator Author

@kentbrew Answered here: https://twitter.com/BraveSampson/status/854509522378993665 🙂

This was referenced May 10, 2017
Closed
Closed
@jonathansampson jonathansampson added this to the 0.15.400 milestone May 10, 2017
This was referenced May 10, 2017
Closed
Closed
Closed
Closed
Closed
Closed
@jonathansampson
Copy link
Collaborator Author

@kentbrew Perhaps you can help me with something: I see that Pinterest uses chrome.notifications, but I'm not able to actually trigger a notification in Brave or Chrome. Does this portion of the extension work as expected for you and your team?

This was referenced May 11, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@jonathansampson
Copy link
Collaborator Author

@kentbrew Friendly-bump on #6366 (comment) :) Any input from you/your team would be greatly appreciated.

@jonathansampson jonathansampson mentioned this issue May 19, 2017
Closed
bridiver pushed a commit to brave/muon that referenced this issue Jun 11, 2017
@kevinlawler @bridiver
Add chrome.cookies.{getAll, set, get} for Pinterest Save Button exten…
6fccc63 
…sion

(commit split from Pinterest key)

brave/browser-laptop#6366
brave/browser-laptop#6262
brave/browser-laptop#8389
hferreiro pushed a commit to brave/muon that referenced this issue Jun 13, 2017
@kevinlawler @hferreiro
Add chrome.cookies.{getAll, set, get} for Pinterest Save Button exten…
9290284 
…sion

(commit split from Pinterest key)

brave/browser-laptop#6366
brave/browser-laptop#6262
brave/browser-laptop#8389
@alexwykoff alexwykoff removed this from the 0.18.x (Developer Channel) milestone Jun 13, 2017
hferreiro pushed a commit to brave/muon that referenced this issue Jun 14, 2017
@kevinlawler @hferreiro
Add chrome.cookies.{getAll, set, get} for Pinterest Save Button exten…
405eb0c 
…sion

(commit split from Pinterest key)

brave/browser-laptop#6366
brave/browser-laptop#6262
brave/browser-laptop#8389
kevinlawler added a commit that referenced this issue Jun 16, 2017
@kevinlawler
offer pinterest-save extension
3b3503f 
#6366

works with base64 extension changes to muon
see brave/muon@b346a92

Auditors:
@bridiver @jonathansampson

Test Plan:
kevinlawler added a commit that referenced this issue Jun 16, 2017
@kevinlawler
offer pinterest-save extension
59d32fc 
#6366

works with base64 extension changes to muon
see brave/muon@b346a92

Auditors:
@bridiver @jonathansampson

Test Plan:

linting

Auditors:

Test Plan:
@kevinlawler kevinlawler mentioned this issue Jun 16, 2017
Merged
8 tasks
kevinlawler added a commit that referenced this issue Jun 16, 2017
@kevinlawler
offer pinterest-save extension
0ab7e02 
#6366

works with base64 extension changes to muon
see brave/muon@b346a92

Auditors:
@bridiver @jonathansampson

Test Plan:

linting

Auditors:

Test Plan:

move public keys to config file
Auditors:

Test Plan:
NejcZdovc pushed a commit that referenced this issue Jun 26, 2017
@kevinlawler @NejcZdovc
offer pinterest-save extension
33316ae 
#6366

works with base64 extension changes to muon
see brave/muon@b346a92

Auditors:
@bridiver @jonathansampson

Test Plan:

linting

Auditors:

Test Plan:

move public keys to config file
Auditors:

Test Plan:
hferreiro pushed a commit to brave/muon that referenced this issue Jun 29, 2017
@kevinlawler @hferreiro
Add chrome.cookies.{getAll, set, get} for Pinterest Save Button exten…
97a7465 
…sion

(commit split from Pinterest key)

brave/browser-laptop#6366
brave/browser-laptop#6262
brave/browser-laptop#8389
@bbondy bbondy added this to the 0.18.x (Beta Channel) milestone Jul 4, 2017
@bbondy
Copy link
Member

bbondy commented Jul 11, 2017

@Sampson is going to split this into an MVP tracking issue and an all issues tracking issue. The former on the milestone and not the latter.

@alexwykoff alexwykoff modified the milestones: 0.19.x (Beta Channel), 0.18.x (Release Channel) Jul 18, 2017
@alexwykoff alexwykoff self-assigned this Jul 25, 2017
@alexwykoff alexwykoff modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Aug 1, 2017
@ghost ghost self-assigned this Aug 16, 2017
@ghost ghost added the Epic label Aug 21, 2017
@ghost ghost removed this from the 0.20.x (Developer Channel) milestone Aug 22, 2017
@luixxiul luixxiul unassigned ghost Nov 2, 2017
@NejcZdovc NejcZdovc removed the Epic label Nov 7, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton
Copy link
Member

When we move to brave-core (which is just around the corner), we should have full support for extensions. Stay tuned 😄

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 24, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

@alexwykoff alexwykoff

Labels
bug feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. project-tracking wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kentbrew @jonathansampson @bbondy @alexwykoff @bsclifton @NejcZdovc