Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Advanced Settings from Brave Payments" not saved #6241

Closed
mideava opened this issue Dec 15, 2016 · 8 comments
Closed

"Advanced Settings from Brave Payments" not saved #6241

mideava opened this issue Dec 15, 2016 · 8 comments

Comments

@mideava
Copy link

mideava commented Dec 15, 2016

The "Minimum page time before logging a visit" and "Minimum visits for publisher relevancy" in "Advanced Settings from Brave Payments" are not saved when changed. I am using Linux Mint Sarah 64 bits.

@cndouglas
Copy link

@mideava Are you using the latest version of Brave (0.12.15)?

@cndouglas cndouglas added feature/rewards needs-info Another team member needs information from the PR/issue opener. labels Dec 16, 2016
@da2x
Copy link
Contributor

da2x commented Dec 31, 2016

I’m using the latest version of Brave, and I’m having the exact same issue.

I made a quick video to demonstrate the issue: https://youtu.be/X6dMXcowi-g

@mrose17 mrose17 self-assigned this Jan 19, 2017
@mrose17 mrose17 added this to the 0.13.2 milestone Jan 19, 2017
@mrose17 mrose17 added bug and removed needs-info Another team member needs information from the PR/issue opener. labels Jan 19, 2017
@mrose17
Copy link
Member

mrose17 commented Jan 19, 2017

i can confirm that 0.12.15 has this issue on linux. with the help of @posix4e i'm going to take a look at 0.13.

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

the issue is fixed in the 0.13.1-branch!

(UPDATE by @bsclifton 0.13.1 is now known as 0.13.2)

@mrose17 mrose17 modified the milestones: 0.13.1, 0.13.2 Jan 20, 2017
@mrose17 mrose17 closed this as completed Jan 20, 2017
@bsclifton
Copy link
Member

@mrose17 can you add test steps to verify the fix here?

Also was this fixed with #6706? If so, could you add "Fixes #6241" to the original post of the PR

Thanks 😄

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

my PR didn't fix the issue... i suspect it had been fixed in 0.13.x for a while. i seem to recall @jkup looking into something similar in the last few weeks.

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

in terms of testing this: @da2x was kind enough to include a link to a youtube video showing the problem. if you try to reproduce that by hand, you'll see the right thing happens...

@bsclifton
Copy link
Member

bsclifton commented Jan 20, 2017

Test steps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.