Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Menu will not disappear #6236

Closed
darkdh opened this issue Dec 15, 2016 · 5 comments · Fixed by #6250
Closed

Menu will not disappear #6236

darkdh opened this issue Dec 15, 2016 · 5 comments · Fixed by #6250
Assignees
@bsclifton
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.13.0

Comments

@darkdh
Copy link
Member

darkdh commented Dec 15, 2016

Brave Version: 814b46b
Muon Version: brave/muon@91d74aa
eqnwopsifu

CC @bsclifton
@darkdh darkdh added this to the 0.13.0 milestone Dec 15, 2016
@bsclifton
Copy link
Member

I had this happen to me also, running locally... I was also unable to close tabs

@bsclifton bsclifton self-assigned this Dec 16, 2016
@bsclifton bsclifton mentioned this issue Dec 16, 2016
Merged
4 tasks
@srirambv
Copy link
Collaborator

Settings page is unusable when opened from hamburger menu
ezgif com-video-to-gif

@srirambv
Copy link
Collaborator

Even the menu bar pull down doesn't close when selected.
feedback

Browser becomes unusable when this is selected. Have to close and reopen to use

@luixxiul luixxiul mentioned this issue Dec 16, 2016
Closed
@luixxiul luixxiul changed the title Hamburger menu will not disappear Menu will not disappear Dec 16, 2016
@luixxiul luixxiul mentioned this issue Dec 17, 2016
Closed
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
cezaraugusto pushed a commit that referenced this issue Dec 20, 2016
@bsclifton @cezaraugusto
Put back in handler for null/empty context menu detail. This is requi…
3e36a71 
…red in order to hide any ContextMenu object

Caused by 7fb2e4c#diff-733d30fbf34816322d3f25dd59c1eb99

Fixes #6236

Auditors: @bridiver, @darkdh

Test Plan:
1. Launch Brave and use the kabob / cheeseburger icon
2. Notice the context menu comes up
3. Click anywhere on the screen (outside of the context menu)
4. Notice context menu closes itself
@luixxiul
Copy link
Contributor

I added release-notes/exclude as the issue appeared and was fixed within the same milestone.

@luixxiul
Copy link
Contributor

Test Plan:

  1. Launch Brave and use the kabob / cheeseburger icon
  2. Notice the context menu comes up
  3. Click anywhere on the screen (outside of the context menu)
  4. Notice context menu closes itself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Put back in handler for null/empty context menu detail. This is requi…
4 participants
@luixxiul @bsclifton @darkdh @srirambv