Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Apply commonForm to addEditBookmarkHanger.js #6040

Closed
luixxiul opened this issue Dec 6, 2016 · 1 comment
Closed

Apply commonForm to addEditBookmarkHanger.js #6040

luixxiul opened this issue Dec 6, 2016 · 1 comment
Assignees
@luixxiul
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 6, 2016 •
edited
Loading

Test plan

#8136 (comment)

#6035 (comment)

Bonus points for replacing that heavy black close button with the svg from the stop loading button. : )

screenshot 2016-12-06 14 24 31

@bradleyrichter I have replaced the close button for the modal dialog with the SVG button in 21ece29#diff-a12551e83f49ce14bb3d831f382ff9acR106 of #6009

This is a sub-task of #6040

#8010
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/bookmarks labels Dec 6, 2016
@luixxiul luixxiul mentioned this issue Dec 6, 2016
Merged
4 tasks
@luixxiul luixxiul mentioned this issue Dec 21, 2016
Closed
@luixxiul luixxiul added this to the Backlog milestone Dec 26, 2016
@luixxiul luixxiul changed the title Apply ModalOverlay to addEditBookmarkHanger.js Apply commonForm to addEditBookmarkHanger.js Apr 3, 2017
@luixxiul luixxiul removed this from the Backlog milestone Apr 3, 2017
@luixxiul luixxiul self-assigned this Apr 3, 2017
This was referenced Apr 3, 2017
Closed
Merged
Merged
@luixxiul luixxiul added this to the 0.14.3 milestone Apr 10, 2017
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue May 3, 2017
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented May 3, 2017

Follow up to the fix: #8646

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
3 participants
@alexwykoff @luixxiul @srirambv