Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor download handling so it works with node removal from window renderer #5947

Closed
bbondy opened this issue Nov 30, 2016 · 2 comments
Closed

Refactor download handling so it works with node removal from window renderer #5947

bbondy opened this issue Nov 30, 2016 · 2 comments
Assignees
@bbondy
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Nov 30, 2016

No description provided.

@bbondy bbondy added this to the 0.13.0 milestone Nov 30, 2016
@cndouglas cndouglas changed the title Opening downloaded files and reveil location on downloads doesn't work in C54 Opening downloaded files and reveal location on downloads doesn't work in C54 Nov 30, 2016
@bbondy bbondy self-assigned this Dec 1, 2016
@bbondy bbondy changed the title Opening downloaded files and reveal location on downloads doesn't work in C54 Refactor download handling so it works with node removal from window renderer Dec 1, 2016
bbondy added a commit that referenced this issue Dec 5, 2016
@bbondy
Refactor download handling so it works with node removal from window …
52711c7 
…renderer

Auditors: @bsclifton

Fix #5947
@bbondy
Copy link
Member Author

bbondy commented Dec 5, 2016

Closing this even know it's not on master since it's on chromium54 and that will be merged soon.
52711c7

@bbondy bbondy closed this as completed Dec 5, 2016
bridiver pushed a commit that referenced this issue Dec 9, 2016
@bbondy @bridiver
Refactor download handling so it works with node removal from window …
39accd8 
…renderer

Auditors: @bsclifton

Fix #5947
posix4e pushed a commit that referenced this issue Dec 12, 2016
@bbondy @posix4e
Refactor download handling so it works with node removal from window …
4cb5dfc 
…renderer

Auditors: @bsclifton

Fix #5947
bridiver pushed a commit that referenced this issue Dec 14, 2016
@bbondy @bridiver
Refactor download handling so it works with node removal from window …
8feebec 
…renderer

Auditors: @bsclifton

Fix #5947
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@bbondy
Copy link
Member Author

bbondy commented Jan 16, 2017 •
edited by luixxiul
Loading

Test plan:

download
pause and resume it
open download location
download the file.

Test you can cancel the download as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @srirambv @cndouglas