Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Insecure icon briefly displayed even for https sites wrongly #5490

Closed
bbondy opened this issue Nov 8, 2016 · 10 comments · Fixed by #5498
Closed

Insecure icon briefly displayed even for https sites wrongly #5490

bbondy opened this issue Nov 8, 2016 · 10 comments · Fixed by #5498
Assignees
@diracdeltas @bsclifton
Labels
bug feature/URLbar security

Comments

@bbondy
Copy link
Member

bbondy commented Nov 8, 2016

Did you search for similar issues before submitting this one?

  • Brave Version:
    0.12.9

  • Steps to reproduce:

    1. Open a new tab
    2. Load https://twitter.com
    3. Notice the insecure icon comes up momentarily

I think we're just defaulting to that icon or something before proper information is determined.
@bbondy bbondy added this to the 0.12.9dev milestone Nov 8, 2016
@diracdeltas
Copy link
Member

to fix #5238, we may have to actually wait til load success to show the secure icon

@diracdeltas
Copy link
Member

@bsclifton i'm going to re-assign this to myself because it's closely related to #5238

@diracdeltas diracdeltas assigned diracdeltas and unassigned bsclifton Nov 8, 2016
@bsclifton
Copy link
Member

@diracdeltas let me check in what I have- will hit you up over Slack 😄

bsclifton added a commit that referenced this issue Nov 9, 2016
@bsclifton
Don't show HTTP icon while site is loading (since it may be HTTPS)
5837fc5 
Fixes #5490

Includes breaking the urlbar icon into it's own control (along with click/drag events)

Auditors: @jkup, @bbondy

Test Plan:
1. Launch Brave and open a new tab
2. Type in "https://twitter.com" and get really close to your screen
3. Hit enter and notice you do not see the yellow triangle at any time
@bsclifton
Copy link
Member

My part of the fix (including a small refactor) was done with 5837fc5

@diracdeltas will take it from here 😄

@diracdeltas diracdeltas removed their assignment Nov 9, 2016
@diracdeltas
Copy link
Member

i will do the other fix on top of @bsclifton 's work once its merged into master

@bsclifton bsclifton mentioned this issue Nov 9, 2016
Merged
4 tasks
diracdeltas added a commit to brave/muon that referenced this issue Nov 9, 2016
@diracdeltas
Add webview event for security state changes
ca0aefe 
Needed to address
brave/browser-laptop#5490 and
brave/browser-laptop#5238

Auditors: @bsclifton @bbondy
@diracdeltas diracdeltas mentioned this issue Nov 9, 2016
Merged
@diracdeltas
Copy link
Member

reopening per #5498 (comment)

@diracdeltas diracdeltas reopened this Nov 9, 2016
@bsclifton
Copy link
Member

Manually marking as closed; should have been fixed with #5501 😄

@diracdeltas
Copy link
Member

diracdeltas commented Nov 9, 2016 •
edited
Loading

actually not closed with #5501 it turns out, though the flickering is less than it was before. i'll deprioritize this though.

@diracdeltas diracdeltas reopened this Nov 9, 2016
@diracdeltas diracdeltas added this to the 1.0.1 milestone Nov 17, 2016
@diracdeltas diracdeltas removed this from the 0.12.10 release milestone Nov 17, 2016
@cndouglas cndouglas changed the title Insecure icon briefly displayed even for https sites wrongly in 0.12.9 Insecure icon briefly displayed even for https sites wrongly Dec 2, 2016
@srirambv
Copy link
Collaborator

srirambv commented Jan 2, 2017

Icon disappears momentarily after showing the insecure icon and right before the page content is loaded
Brave 0.13.0
rev 0c7a64d
5420

@bsclifton bsclifton mentioned this issue Feb 12, 2017
Closed
@jonathansampson
Copy link
Collaborator

This does not appear to repro for me in 0.15.303. If anybody else sees this issue pop up, feel free to re-open.

@luixxiul luixxiul removed this from the 1.0.1 milestone May 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@bsclifton bsclifton

Labels
bug feature/URLbar security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't show HTTP icon while site is loading (since it may be HTTPS) brave/browser-laptop
7 participants
@diracdeltas @jonathansampson @bbondy @luixxiul @bsclifton @srirambv @cndouglas