Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Navigation bar no longer centered #5476

Closed
jkup opened this issue Nov 7, 2016 · 8 comments
Closed

Navigation bar no longer centered #5476

jkup opened this issue Nov 7, 2016 · 8 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression

Comments

@jkup
Copy link
Contributor

jkup commented Nov 7, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
The urlbar isn't centered correctly.

Expected behavior:
It should be evenly spaced between the back/forward buttons and the brave icon.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version:
    master branch
    pasted image at 2016_11_07 09_51 pm
    pasted image at 2016_11_07 09_58 pm

  • Screenshot if needed:

@jkup jkup added design A design change, especially one which needs input from the design team. regression labels Nov 7, 2016
@jkup jkup added this to the 0.12.10 release milestone Nov 7, 2016
@jkup jkup self-assigned this Nov 7, 2016
@jkup
Copy link
Contributor Author

jkup commented Nov 11, 2016

@bradleyrichter what is the desired look here? Should the white urlbar be centered re: the browser window or equidistant from the buttons on both sides?

@bradleyrichter
Copy link
Contributor

that was the goal. (unless we decided to switch over to left-aligned.)

@jkup
Copy link
Contributor Author

jkup commented Nov 11, 2016

@bradleyrichter haha which one was the goal?

@bradleyrichter
Copy link
Contributor

actually centered...

@srirambv
Copy link
Collaborator

Almost centered 👍

image

@luixxiul
Copy link
Contributor

@bradleyrichter how about adding left: calc(38px / 2); to #navigator, because margin-right: 38px; is set to .navigatorWrapper #navigator?

@bradleyrichter
Copy link
Contributor

excellent idea…since we need that preserved grab area on the right..

On Nov 21, 2016, at 5:58 AM, Suguru Hirahara notifications@github.com wrote:

@bradleyrichter https://github.com/bradleyrichter how about adding left: calc(38px / 2); to #navigator, because margin-right: 38px; is set to .navigatorWrapper #navigator?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #5476 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AM4jqsgWjGaCF1BNvROLoLMQmhWDdkx_ks5rAaOAgaJpZM4Kr04l.

@luixxiul
Copy link
Contributor

OK I will check it out. the margin-right is set with the variable @rightMargin: @navbarLeftMarginDarwin / 2; btw.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/navbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression
Projects
None yet
Development

No branches or pull requests

5 participants