Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Monthly ledger payment failed #5371

Closed
da2x opened this issue Nov 3, 2016 · 4 comments
Closed

Monthly ledger payment failed #5371

da2x opened this issue Nov 3, 2016 · 4 comments

Comments

@da2x
Copy link
Contributor

da2x commented Nov 3, 2016

My payment failed yesterday. The below is the entire contents of my Brave_Payments_11-3-2016.csv file:

Publisher,Votes,Fraction,BTC,USD

(data:text/csv;base64,UHVibGlzaGVyLFZvdGVzLEZyYWN0aW9uLEJUQyxVU0Q=)

My ledger wasn’t wiped clean as it was last month, but still has all of the entries, visits, and time spent from October. Status now shows “Contribution due date: ⁨in a month⁩.”

Last month my Brave client was running when the payment was performed. This month, I opened up Brave some hour after the payment was expected to go through.

Version v0.12.7-dev on Fedora Linux. Possibly related to #4703. My Brave Wallet balance was about 31 USD before the due payment and is now about 29 USD. Some funds lost to transaction fees?

@mrose17 mrose17 added the bug label Nov 8, 2016
@mrose17 mrose17 added this to the 0.12.11 milestone Nov 8, 2016
@mrose17
Copy link
Member

mrose17 commented Nov 17, 2016

sorry for the delay in replying. i see what's going on (finally!).

@willy-b -- what's going on here is that we're saying a report is ready before the voting has occurred. the entry in the transaction doesn't have any of these fields: credential, surveyorIds, count, satoshis, votes, or ballots

i suggest that if ballets is not present, or ballets.length !== count, then we don't say that a report is ready for that contribution period. your thoughts?

@da2x
Copy link
Contributor Author

da2x commented Jan 5, 2017

This just happen again.

Account balance hasn’t been deducted, I have an empty report/receipt for the month, ledger hasn’t been reset, and I got a toolbar notification saying my contributions have been processed. There haven’t been a release since this was fixed, but I wanted to update the record of this bug all the same.

Brave 0.12.15 on Fedora Linux.

@luixxiul
Copy link
Contributor

Reopening this based on the comment above. Please close this with a new commit/PR, thanks.

@bbondy
Copy link
Member

bbondy commented Jan 17, 2017

@luixxiul looks like this was already fixed as per the message from da2x above, just not released. He was just updating, so I'll close this again.

The release will be out soon by the way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants