Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtabs - drag and drop not working for Top Sites items #5336

Closed
bsclifton opened this issue Nov 2, 2016 · 3 comments · Fixed by #5354
Closed

about:newtabs - drag and drop not working for Top Sites items #5336

bsclifton opened this issue Nov 2, 2016 · 3 comments · Fixed by #5354
Assignees
@cezaraugusto
Labels
feature/newtab needs-info Another team member needs information from the PR/issue opener. QA/checked-macOS regression
Milestone
0.12.9dev

Comments

@bsclifton
Copy link
Member

It seems the drag is working but not the drop ☹️

May be related to the code that needs to change with #5321
@bsclifton bsclifton added this to the 0.12.9dev milestone Nov 2, 2016
@bsclifton
Copy link
Member Author

bsclifton commented Nov 2, 2016 •
edited
Loading

At first, I thought that maybe it was failing because I didn't have the npm package installed. I cleared and re-ran npm install and still get the problem.

Opening a console shows this:
browser.js:40 Uncaught Invariant Violation: Cannot call hover while not dragging.invariant @ browser.js:40hover @ dragDrop.js:116(anonymous function) @ DragDropManager.js:74handleTopDrop @ HTML5Backend.js:540

bsclifton pushed a commit that referenced this issue Nov 2, 2016
@cezaraugusto @bsclifton
Fix drag-n-drop for topSites grid
6cb8b2a 
Fixes #5336

Auditors: @bsclifton

Test Plan:

* Copy/paste this file to session-store-1: https://raw.githubusercontent.com/cezaraugusto/brave-json/master/newtab-3-rows.json
* Check that now we have 18 tiles on our grid
* Randomly drag tiles and check that it can be dropped on any position
* Open a new new tab and ensure items keep their previous indexes
@bsclifton bsclifton mentioned this issue Nov 2, 2016
Merged
4 tasks
This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
@srirambv
Copy link
Collaborator

@cezaraugusto doesn't work for me on Windows

5336_fail

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Nov 16, 2016
@cezaraugusto
Copy link
Contributor

@srirambv couldn't reproduce, drag and drop is working, also changes (switching order) are saved after closing/reopening the app. Running 0.12.9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/newtab needs-info Another team member needs information from the PR/issue opener. QA/checked-macOS regression
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Fix drag and drop for about:newtab (and other fixes) brave/browser-laptop
5 participants
@alexwykoff @luixxiul @cezaraugusto @bsclifton @srirambv