This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
about:bookmarks multiselect should be reset following drag-and-drop #5249
Milestone
Comments
|
cc @bsclifton |
|
@bsclifton Can I press to have this issue labelled as "bug"? I've never seen drag-and-drop from a multiselect work in this way in a browser's bookmark manager or in any other application. |
|
@CliqueBait done 😄 I'll work on fixing this soon- thanks for filing this |
bbondy
pushed a commit
that referenced
this issue
Nov 2, 2016
- clear selection when click is outside of table - clear selection when any element is dragged Fixes #5223 Fixes #5249 Auditors: @darkdh Test Plan: 1. Launch Brave and visit about:bookmarks 2. Import bookmarks or have bookmarks ready 3. Drag bookmarks from the view on the right over to a different folder 4. Observe that the selection is cleared 5. Use Ctrl or Cmd and select multiple items 6. Click below the table or click the header for the table 7. Notice the selection is cleared
This was referenced Nov 2, 2016
This was referenced Nov 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The ability to multiselect bookmarks within about:bookmarks is a welcome addition to 0.12.7dev so work should continue on it.
I've noticed that when I multiselect a set of bookmarks and then drag-and-drop those bookmarks into a different folder the bookmarks are correctly moved to the destination folder but the pattern of selected rows is not reset/cleared in the source folder. Bookmarks remaining in the source folder which happen to move into the selected rows are now selected and subject to a drag-and-drop action but it seems unlikely that that is what a user would want to do next.
To illustrate, notice that I have selected both the bookmark for google and the bookmark for bing:
Moving the two selected bookmarks to another folder keeps the selection pattern which happens to land on yahoo and startpage:
Ubuntu 16.10
Brave: 0.12.7
Electron: 1.4.20
libchromiumcontent: 53.0.2785.143
V8: 5.3.332.47
Node.js: 6.5.0
Update Channel: dev
The text was updated successfully, but these errors were encountered: