Regression : when using cmd+l to access the urlbar, any newly typed characters should replace the existing url instead of appending

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When I was trying to visit a new site by using cmd+l, I noticed that I had to use the delete key first otherwise my expected new url was just postpending to the current url.

Expected behavior:
Like all prior builds, the current content of the urlbar should be replaced by any newly typed or pasted characters.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on OS X, confirmed on Windows.
• Brave Version:
  0.12.3 RC3
• Steps to reproduce:
  1. Visit a site.
  2. Use cmd+l (ctrl+l for windows) to move the cursor to and highlight the contents of the urlbar.
  3. Start typing a new url.
• Any related issues:
  Likely introduced by urlbar empty when hitting cmd+L sometimes #4851

[diracdeltas]

your report says 0.12.3 RC3 - is that supposed to be 0.12.5 ?

[Sh1d0w]

This is caused by b949a84

Reverting this will resolve the bug.

[diracdeltas]

@Sh1d0w i'm working on fixing. reverting that commit causes another bug.

[Sh1d0w]

@diracdeltas Ok cool, I was just mentioning, because I am testing it locally on latest master. I tried to reproduce the bug you reported earlier today (and which your commit fixes) when I reverted your commit, but I wasn't able to reproduce it at least not on Linux :)