Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave Browser very slow to open or close tabs #4848

Closed
jrshonka opened this issue Oct 16, 2016 · 12 comments · Fixed by #9191
Closed

Brave Browser very slow to open or close tabs #4848

jrshonka opened this issue Oct 16, 2016 · 12 comments · Fixed by #9191

Comments

@jrshonka
Copy link

jrshonka commented Oct 16, 2016

Test plan

  1. Have a large number of bookmarks
  2. Open a few of those bookmarks
  3. Close each, one at a time. Should close immediately

for more info, see #9191 (comment)

Original issue description

Did you search for similar issues before submitting this one? Yes I did.

Describe the issue you encountered:
I have recently (about 2 weeks ago) installed Brave browser and I am finding it very slow when I open and close tabs. Also, it occasionally "locks up", and I have to re-start it.
Expected behavior:
I expected it to be as fast or faster than Chrome

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 with 64-bit
  • Brave Version:
    0.12.4
  • Steps to reproduce:
    1. open browser
    2. go to Google, do a search
    3. open a couple of other tabs, like Amazon or my utility company
    4. try to close a tab - it takes about 12-13 seconds to close.
  • Screenshot if needed:
  • Any related issues:
@Sh1d0w Sh1d0w added OS/Windows needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels Oct 16, 2016
@bsclifton bsclifton added the perf label Oct 17, 2016
@bbondy
Copy link
Member

bbondy commented Oct 17, 2016

let me know if this is improved with 0.12.5 when it is released please.

@Blitzkrieg77
Copy link

Blitzkrieg77 commented Jan 13, 2017

I also have the same problem. My computer is lightning fast, no issues with performance. There just happens to be some sort of an odd glitch where Brave is slow when closing out tabs. It gives a bit of a 'clunky' feel to the browser overall.

This has been an issue since at least October 16, 2016 and before, I see...

This browser has so much potential, yet this issue is so annoying. Please fix this!

For the record, my system is running on Windows 8, 64-bit.

I'd also like to add to this that the "forward" and "back" buttons don't always respond when hovering the mouse over them. I think this has to do with the size and area covered by the buttons, though, as opposed to a performance problem.

Edit: Going through bookmarks is also sluggish.

@bsclifton
Copy link
Member

@Blitzkrieg77 we should have a new preview build for an upcoming release available soon (next day or so). Would you be up for trying it to see if performance is better?

@Blitzkrieg77
Copy link

@bsclifton

Sure. I wouldn't mind testing it out at all. I think the browser you're continuing to develop is great so far. I'll check back here and on the Brave website for the update. Looking forward to it.

Thanks.

@Renegilo
Copy link

To date the issue still has not been fixed in version 12:15

@DerekTurtleRoe
Copy link

I am still having this issue, and I am using the latest version of Brave on a fully updated Windows 10 Pro build.

@ayumi ayumi changed the title Brave Browser very slow on Windows 10 64-bit system Brave Browser very slow to open or close tabs May 23, 2017
@ayumi ayumi self-assigned this May 23, 2017
ayumi added a commit that referenced this issue Jun 1, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Auditors: @bsclifton @bbondy

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
ayumi added a commit that referenced this issue Jun 1, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Auditors: @bsclifton @bbondy

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
ayumi added a commit that referenced this issue Jun 1, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Auditors: @bsclifton @bbondy

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@NejcZdovc NejcZdovc added this to the 0.17.x (Frozen, only critical adds from here) milestone Jun 2, 2017
ayumi added a commit that referenced this issue Jun 3, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Auditors: @bsclifton @bbondy

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@luixxiul luixxiul added bug and removed needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. OS/Windows labels Jun 4, 2017
ayumi added a commit that referenced this issue Jun 5, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Auditors: @bsclifton @bbondy

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@makupi
Copy link

makupi commented Jun 6, 2017

Having similar issues here. Happens from time to time that a tab pops out as a new window and when i try to put it back in it freezes and i can't close/open tabs anymore and have to restart brave.

ayumi added a commit that referenced this issue Jun 8, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@saskakol
Copy link

saskakol commented Jun 8, 2017

Just started having similar issues after updating to the latest version of Brave. Locking up when opening/closing/switching tabs, occasionally even locks up for a few seconds during regular browsing, etc.

@naman
Copy link

naman commented Jun 13, 2017

v0.16.9 Still facing sluggish performance while opening/closing new tab, searching through the bar, organizing bookmarks

@bsclifton
Copy link
Member

Hi @naman,

We should have improvements with regards to closing the tab shipped in our next version, 0.17. We are also tracking some of the critical performance issues here:
#9311

bridiver pushed a commit that referenced this issue Jun 14, 2017
Improves performance of tab close and undo tab close by avoiding iterating over all bookmarks
and avoiding recreating the system app menu.

Fix #4848

Note this should be tested on Linux, MacOS and Windows to confirm tab closing is okay.

Test plan:
1. Open the History menu and note Recently closed is not there.
2. Go to https://archive.org
3. Open a new tab and go to https://wikipedia.org
4. Close the tab
5. Examine the menu History > Recently closed; it should have Wikipedia
6. Close the archive.org tab
7. Examine the Recently closed menu; it should have the Internet archive
8. Use the menu item "Reopen last closed tab" or use the shortcut
9. Examine the Recently closed menu; it should be hidden now.
@Kandwarf
Copy link

Kandwarf commented Jul 2, 2017

I am still having this issue running Brave on my macbook pro. I love the browser, but this is an issue that needs SERIOUS attention. Opening and closing tabs should feel quick! right now it indeed feels very clunky. even worse, when I try and do these operations very quickly sometimes the whole tab bar locks up and i cant switch/open/close ANY tabs! This is a critical fault, please investigate this further!

@luixxiul
Copy link
Contributor

luixxiul commented Jul 2, 2017

that issue is recognized. thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.