Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

background color of modal window on ledger advanced settings gets darker by clicking backup wallet button #4808

Closed
luixxiul opened this issue Oct 15, 2016 · 1 comment · Fixed by #4820
Closed

background color of modal window on ledger advanced settings gets darker by clicking backup wallet button #4808

luixxiul opened this issue Oct 15, 2016 · 1 comment · Fixed by #4820
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: the background color of modal window on the ledger advanced settings gets darker by clicking the backup wallet button.

Expected behavior: it should be the same.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Steps to reproduce:
    1. Go to about:preferences#advanced
    2. Click Advanced Settings
    3. Click "backup your wallet"
  • Any related issues:
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. feature/rewards labels Oct 15, 2016
@luixxiul luixxiul mentioned this issue Oct 15, 2016
Closed
@willy-b willy-b mentioned this issue Oct 15, 2016
Merged
3 tasks
@mrose17 mrose17 modified the milestones: 1.0.0, 0.12.7dev, 0.12.8dev Oct 17, 2016
@mrose17 mrose17 modified the milestones: 1.1.0, 0.12.8dev Oct 25, 2016
cezaraugusto pushed a commit that referenced this issue Dec 7, 2016
@willy-b @cezaraugusto
modal overlays: all but top overlay should have transparent background (
2728303 
#4820)

- tried several CSS-only solutions for ensuring only the top-most modal had a gray background,
  but I think using some JS is actually simpler, so that is what I did here

- keeping modalOverlay background when opening iframe w/ Coinbase widget
  (decision made w/ @bsclifton after trying alternatives)

fixes #4808
@luixxiul luixxiul modified the milestones: 0.13.0, 1.1.0 Dec 7, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test plan: #4820 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

When Modal Overlays are layered, only bottom layer has a dark background (fix #4808)
3 participants
@mrose17 @luixxiul @srirambv