Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Cannot save bookmark outside of bookmarks toolbar #4202

Closed
olimay opened this issue Sep 22, 2016 · 6 comments
Closed

Cannot save bookmark outside of bookmarks toolbar #4202

olimay opened this issue Sep 22, 2016 · 6 comments
Assignees
@NejcZdovc
Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@olimay
Copy link

olimay commented Sep 22, 2016 •
edited by luixxiul
Loading

Test plan

Make sure you are able to bookmark a page to Other Bookmarks

I can't seem to save bookmarks in any folder outside the Bookmarks Toolbar folder. Saving to the Bookmarks Toolbar folder and any subfolders appear to work correctly.

  • Platform: OS X 10.11.6
  • Brave Version: 0.12.1
  • Steps to reproduce:
    1. Click the star next to a page's URL.
    2. Click the folder dropdown.
    3. Bookmark folders outside of the Bookmarks Toolbar folder will not be visible in the dropdown.

Here are the bookmark folders in the Bookmarks Manager.

image

Here are the places to save the bookmark that are available in the dropdown.

image
#1658
@luixxiul luixxiul mentioned this issue Sep 24, 2016
Closed
@lucidNTR
Copy link
Contributor

+1

@luixxiul luixxiul added the bug label May 28, 2017
This was referenced May 28, 2017
Closed
Closed
Closed
@luixxiul luixxiul added this to the 1.0.1 milestone May 28, 2017
@LaurenWags
Copy link
Member

+1 from community: https://community.brave.com/t/my-bookmarks-are-not-showing-up-in-the-bookmark-manager/4573/16

Specifically, user has folders under the 'Other Bookmarks' folder in Bookmark manager. However, when adding a bookmark from the star icon and choosing a folder from the bookmark hanger, the 'Other Bookmarks' and subfolders are not available for selection.

@NejcZdovc
Copy link
Contributor

@LaurenWags is this dup of #10157?

@LaurenWags
Copy link
Member

@NejcZdovc I believe #10157 is focused on the bookmark manager drag/drop functionality while this one is for the bookmark hanger (when you click on the star icon to create a bookmark or right click on a bookmark in the toolbar to edit and update the folder).

@NejcZdovc
Copy link
Contributor

Yeah I can see it like that, but root cause is the same, Other bookmarks folder is not working. Probably I will be fixing this one, so I will close all of them related to Other bookmarks.

@NejcZdovc NejcZdovc self-assigned this Aug 21, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 1.0.1 Aug 21, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 21, 2017
@NejcZdovc
Fixes Other bookmarks not being usable
440661c 
Resolves brave#10157
Resovles brave#4202

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 21, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 21, 2017
@NejcZdovc
Fixes Other bookmarks not being usable
e021002 
Resolves brave#10157
Resolves brave#4202

Auditors:

Test Plan:
@eljuno
Copy link
Contributor

eljuno commented Sep 8, 2017

+1 from community https://community.brave.com/t/other-bookmarks-not-listed/7352?u=eljuno

@ghost ghost added the sprint/1 label Sep 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 18, 2017
@NejcZdovc
Fixes Other bookmarks not being usable
d6de9fc 
Resolves brave#10157
Resolves brave#4202

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 26, 2017
@NejcZdovc
Fixes Other bookmarks not being usable
33b6788 
Resolves brave#10157
Resolves brave#4202

Auditors:

Test Plan:
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@bbondy bbondy added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Fixes Other bookmarks not being usable
393f1d8 
Resolves brave#10157
Resolves brave#4202

Auditors:

Test Plan:
@luixxiul luixxiul mentioned this issue Nov 18, 2017
Closed
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
9 participants
@olimay @bbondy @lucidNTR @luixxiul @bsclifton @NejcZdovc @srirambv @eljuno @LaurenWags