Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

noscript and flash site settings should not be shared from private browsing into regular browsing #3835

Closed
diracdeltas opened this issue Sep 9, 2016 · 4 comments

Comments

@diracdeltas
Copy link
Member

following up on #3795 (comment)

@diracdeltas diracdeltas added this to the 0.12.2dev milestone Sep 9, 2016
@diracdeltas diracdeltas self-assigned this Sep 9, 2016
@bbondy
Copy link
Member

bbondy commented Sep 20, 2016

can this move to 0.12.3?

@diracdeltas diracdeltas modified the milestones: 0.12.3dev, 0.12.2dev Sep 20, 2016
@diracdeltas
Copy link
Member Author

moved

@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 26, 2016
@diracdeltas
Copy link
Member Author

related: #3998

diracdeltas added a commit that referenced this issue Sep 30, 2016
Also address #3835 by not
allowing Flash to be allowed persistently.

Auditors: @sririambv

Test Plan:
1. open http://homestarrunner.com/ in a private tab
2. right click to allow Flash once
3. flash should be allowed
4. close the private tab
5. open a regular tab and open http://homestarrunner.com/. flash should be blocked.
@diracdeltas
Copy link
Member Author

also related: #2745

this turns out to be tricky because js/state/contentSettings.js has no awareness of incognito vs regular context. an acceptable solution for now is just for Flash/NoScript settings in private browsing mode to be restricted to 'Allow Once'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants