Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Mixed-content lock control should be able to re-lock and reload the page like Firefox. #3770

Closed
alexwykoff opened this issue Sep 6, 2016 · 1 comment · Fixed by #3808
Closed

Mixed-content lock control should be able to re-lock and reload the page like Firefox. #3770

alexwykoff opened this issue Sep 6, 2016 · 1 comment · Fixed by #3808
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-Win32 QA/checked-Win64 security
Milestone
0.12.1dev

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Sep 6, 2016 •
edited by bradleyrichter
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When testing #3443 it was discovered that re-locking the page exhibits counterintuitive behavior. It merely displays the unlocked status rather than re-locking.

Expected behavior:
If a user clicks on a closed lock, it should open. If a user clicks on an open lock, it should close.

Firefox:
mixed_content_firefox

Brave:
mixed_content_brave
@alexwykoff alexwykoff added this to the 1.1.0 milestone Sep 6, 2016
@diracdeltas diracdeltas changed the title Mixed-content lock control should be able to re-lock and reload the page like Firefox. should be able to re-block mixed content on a page where it is unblocked Sep 7, 2016
@diracdeltas diracdeltas modified the milestones: 0.12.2dev, 1.1.0 Sep 7, 2016
@diracdeltas
Copy link
Member

changing this to higher priority because currently the only way to re-blocked mixed content is by restarting the browser

@bradleyrichter bradleyrichter changed the title should be able to re-block mixed content on a page where it is unblocked Mixed-content lock control should be able to re-lock and reload the page like Firefox. Sep 7, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 8, 2016
@darkdh
1. Add an option to re-block running insecure content
84c37d7 
2. Re-block running insecure content when frame closed

fix brave#3770

Auditors: @diracdeltas

Test Plan:
For re-block option:
1. Go to `https://mixed-script.badssl.com/`
2. Click urlIcon and click `Load Unsafe Scripts`
3. Background should be red
4. Click urlIcon and click `Stop Loading Unsafe Scripts`
5. Background should be grey

For re-blocked on frame closed
1. Go to `https://mixed-script.badssl.com/`
2. Click urlIcon and click `Load Unsafe Scripts`
3. Background should be red
4. Close tab
5. Go to `https://mixed-script.badssl.com/` on new tab again
6. Background should be grey
@darkdh darkdh mentioned this issue Sep 8, 2016
Merged
4 tasks
@bbondy bbondy modified the milestones: 0.12.1dev, 0.12.2dev Sep 9, 2016
This was referenced Sep 10, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 12, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-Win32 QA/checked-Win64 security
Projects
None yet
Milestone
0.12.1dev
Development

Successfully merging a pull request may close this issue.

Re-block running insecure content darkdh/browser-laptop
4 participants
@diracdeltas @bbondy @alexwykoff @darkdh