Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Deleted bookmarks under folder shows up in URL suggestion #3763

Closed
srirambv opened this issue Sep 6, 2016 · 0 comments · Fixed by #4127
Closed

Deleted bookmarks under folder shows up in URL suggestion #3763

srirambv opened this issue Sep 6, 2016 · 0 comments · Fixed by #4127
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.2dev

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 6, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Deleted bookmarks under folder shows up in URL suggestion

Expected behavior:
Deleted bookmarks either from bookmarks bar or under folders should come in auto suggestion when deleted

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windwos 10 x64
  • Brave Version:
    0.12.0 RC2 (Clean Install)
  • Steps to reproduce:
    1. Add a webpage as bookmark
    2. Delete History so as to remove any entries
    3. Create a new bookmark folder
    4. Move the bookmark from the toolbar to inside the folder
    5. Delete browsing history again so as to remove any entries of the webpage
    6. Delete the bookmark folder from the toolbar and delete browsing history again
    7. Type the website address which was bookmarked, shows up in the suggested items under bookmark entries
  • Screenshot if needed:
    bookmark
  • Any related issues:
    Deleted Bookmarks show up in address bar autocomplete #2827
@srirambv srirambv mentioned this issue Sep 7, 2016
Closed
@darkdh darkdh mentioned this issue Sep 20, 2016
Closed
darkdh added a commit to darkdh/browser-laptop that referenced this issue Sep 20, 2016
@darkdh
removeSite should also remove its children
036effa 
fix brave#3763
fix brave#4124

Auditors: @bsclifton

Test Plan:
1. Add folder "folder1" under bookmarks toolbar
2. Add folder "folder2" under "folder1"
3. Bookmark "facebook.com" and put it under "folder1"
4. Bookmark "twitter.com" and put it under "folder2"
5. Delete "folder1"
6. "facebook.com" and "twitter.com" should be unstarred
@darkdh darkdh mentioned this issue Sep 20, 2016
Merged
4 tasks
@darkdh darkdh added this to the 0.12.2dev milestone Sep 20, 2016
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
This was referenced Sep 24, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.2dev
Development

Successfully merging a pull request may close this issue.

removeSite should also remove its children darkdh/browser-laptop
5 participants
@aekeus @alexwykoff @luixxiul @darkdh @srirambv