Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some autofill automated tests are failing #3618

Closed
bbondy opened this issue Aug 31, 2016 · 4 comments · Fixed by #3656
Closed

Some autofill automated tests are failing #3618

bbondy opened this issue Aug 31, 2016 · 4 comments · Fixed by #3656
Assignees
@bridiver @darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified tests
Milestone
0.12.0dev

Comments

@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

screenshot 2016-08-31 13 46 59

/cc @darkdh
@darkdh darkdh self-assigned this Aug 31, 2016
@darkdh
Copy link
Member

darkdh commented Sep 1, 2016

If we want to run test on local for Autofill, we must make sure ~/Library/Application Support/brave/Web Data is removed for now. We plan to add clear autofill and autocomplete function (#3358) and after that we won't need the prerequisite.

@luixxiul luixxiul added the tests label Sep 1, 2016
@bbondy
Copy link
Member Author

bbondy commented Sep 1, 2016

@bridiver we need to use a whole different profile dir for tests for this reason too. Can we set an env var that would be used for dev and test mode to alter the profile dir?

@bridiver bridiver self-assigned this Sep 1, 2016
bridiver added a commit that referenced this issue Sep 2, 2016
@bridiver
allow setting of user data dir
cacf22d 
use a different user data dir for each test run
refactor autofill tests
fixes #3618
@bridiver bridiver mentioned this issue Sep 2, 2016
Merged
3 tasks
bridiver added a commit that referenced this issue Sep 2, 2016
@bridiver
allow setting of user data dir
2a6d5b8 
use a different user data dir for each test run
refactor autofill tests
fixes #3618
bridiver added a commit that referenced this issue Sep 2, 2016
@bridiver
allow setting of user data dir
3c1e03c 
use a different user data dir for each test run
refactor autofill tests
fixes #3618
@bbondy
Copy link
Member Author

bbondy commented Sep 2, 2016

Please verify no data loss for upgrades for things like cookies and for things like bookmarks.

@bbondy bbondy added this to the 0.11.7dev milestone Sep 2, 2016
@bridiver
Copy link
Collaborator

bridiver commented Sep 2, 2016

the change has no effect on release builds

@alexwykoff alexwykoff mentioned this issue Sep 4, 2016
Closed
25 tasks
@alexwykoff alexwykoff mentioned this issue Sep 5, 2016
Closed
30 tasks
This was referenced Sep 5, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/test-plan-specified tests
Projects
None yet
Milestone
0.12.0dev
Development

Successfully merging a pull request may close this issue.

allow setting of user data dir brave/browser-laptop
5 participants
@bridiver @bbondy @alexwykoff @luixxiul @darkdh