Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

PDF reader does not work within a new private tab #2568

Closed
luixxiul opened this issue Jul 18, 2016 · 14 comments
Closed

PDF reader does not work within a new private tab #2568

luixxiul opened this issue Jul 18, 2016 · 14 comments
Assignees
@diracdeltas
Labels
bug
Milestone
0.11.2dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 18, 2016 •
edited
Loading

Describe the issue you encountered: PDF reader does not work within a new session tab

cc: @diracdeltas

Setting a milestone for now
@luixxiul luixxiul added the bug label Jul 18, 2016
@luixxiul luixxiul added this to the 0.11.1dev milestone Jul 18, 2016
@luixxiul luixxiul mentioned this issue Jul 18, 2016
Closed
78 tasks
@bbondy
Copy link
Member

bbondy commented Jul 18, 2016

cc @diracdeltas

@diracdeltas diracdeltas self-assigned this Jul 18, 2016
@bbondy
Copy link
Member

bbondy commented Jul 19, 2016

Moving to 0.11.2

@bbondy bbondy modified the milestones: 0.11.2dev, 0.11.1dev Jul 19, 2016
@luixxiul
Copy link
Contributor Author

It does not work on a new private tab either.

@luixxiul luixxiul changed the title PDF reader does not work within a new session tab PDF reader does not work within a new session/private tab Jul 19, 2016
@bbondy
Copy link
Member

bbondy commented Jul 19, 2016

I don't remember is this the case for other extensions too @bridiver ?

@bridiver
Copy link
Collaborator

afaik all of the other extensions work in session and private tabs. Extensions can run in split or spanning mode and I've tested both types of extensions.

@diracdeltas
Copy link
Member

it does actually load if you reload the PDF in the session tab but not in the private tab

diracdeltas added a commit that referenced this issue Jul 25, 2016
@diracdeltas
Fix PDFJS MIME type detection
611f617 
This reverts the old workaround for pdfjs returning status code 0 errors,
which was causing PDF MIME type detection to stop working in cases
where the URL is loaded directly instead of by navigation. A webview
reload seems to always get rid of the PDF status code 0 error.

This includes a merge of PDFJS latest master, but the fix commit is only
diracdeltas/pdf.js@6c18572

Fix #2633
Fix #2654
Fixes the session tab part of #2568

Auditors: @bbondy
@diracdeltas diracdeltas changed the title PDF reader does not work within a new session/private tab PDF reader does not work within a new private tab Jul 26, 2016
@diracdeltas
Copy link
Member

i see this error when trying to open pdfs in a private tab:

2016-07-26 15:12:36.269 Brave[5447:114231] Communications error: <OS_xpc_error: <error: 0x107900c90> { count = 1, contents =
        "XPCErrorDescription" => <string: 0x107900f78> { length = 18, contents = "Connection invalid" }
}>

@bbondy bbondy modified the milestones: 0.11.3dev, 0.11.2dev Jul 27, 2016
@bbondy
Copy link
Member

bbondy commented Jul 27, 2016

moved to 0.11.3 for now but ok with putting it in 0.11.2 if fixed before we release.

@diracdeltas
Copy link
Member

appears that webRequest listeners are not fired for loads in private tabs

@bbondy
Copy link
Member

bbondy commented Jul 29, 2016

In about:extensions chrome has an option for allow in incognito mode. Maybe we just need to enable out extensions that we bundle there?

@diracdeltas
Copy link
Member

the extensions do load in incognito mode, so i don't think that's the problem. just webrequest listeners don't work.

@diracdeltas
Copy link
Member

fixed in brave/muon@2138301

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 1, 2016

in 0.11.2? @bbondy

@diracdeltas
Copy link
Member

it will be in 0.11.2

@luixxiul luixxiul modified the milestones: 0.11.2dev, 0.11.3dev Aug 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug
Projects
None yet
Milestone
0.11.2dev
Development

No branches or pull requests
4 participants
@bridiver @diracdeltas @bbondy @luixxiul