Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add option to clear site-specific Bravery settings #2545

Closed
luixxiul opened this issue Jul 17, 2016 · 2 comments
Closed

Add option to clear site-specific Bravery settings #2545

luixxiul opened this issue Jul 17, 2016 · 2 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 17, 2016

Expected behavior: Add option to clear site permissions of allowing/disallowing scripts

  • Platform (Win7, 8, 10? macOS? Linux distro?): OS X
  • Brave Version: 0.11.1 Beta1
  • Screenshot if needed:

For example on about:preferences#security,
screenshot 2016-07-18 1 17 01

@diracdeltas diracdeltas self-assigned this Jul 17, 2016
@luixxiul
Copy link
Contributor Author

Also 3rd party cookies.

@diracdeltas
Copy link
Member

I'm going to generalize this ticket to show all Bravery settings in the site permissions table or maybe a separate table

@diracdeltas diracdeltas added this to the 1.0.0 milestone Aug 9, 2016
@diracdeltas diracdeltas changed the title Add option to clear site permissions of allowing/disallowing scripts Add option to clear site-specific Bravery settings Aug 9, 2016
@bradleyrichter bradleyrichter changed the title Add option to clear site-specific Bravery settings Add option to clear site permissions of allowing/disallowing scripts Aug 9, 2016
@diracdeltas diracdeltas changed the title Add option to clear site permissions of allowing/disallowing scripts Add option to clear site-specific Bravery settings Aug 16, 2016
@diracdeltas diracdeltas modified the milestones: 0.12.2dev, 1.0.0 Sep 19, 2016
diracdeltas added a commit that referenced this issue Sep 19, 2016
Fix #2545

Test Plan:
1. browse to some sites and change the Brave settings on them
2. go to about:preferences#shields, and verify that the changed settings appear there
3. change the bravery global defaults and verify that the changed settings disappear
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants