Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab cycling order needs to update when tab is pinned #1983

Closed
stshank opened this issue May 30, 2016 · 1 comment
Closed

Tab cycling order needs to update when tab is pinned #1983

stshank opened this issue May 30, 2016 · 1 comment
Milestone

Comments

@stshank
Copy link

stshank commented May 30, 2016

Describe the issue you encountered:
When I converted a tab to a pinned tab, using allt/cmd-tab to cycle among them treated it as if it were in its original unpinned position.

Expected behavior:
Pinned tabs should move to the first tabs in the cycling order (when starting from the leftmost tab)

  • Platform (Win7, 8, 10? OS X? Linux distro?):
    Windows 10 and OS X
  • Brave Version:
    Brave: 0.10.0
    Electron: 0.37.8
    libchromiumcontent: 50.0.2661.102
    V8: 5.0.71.48
    Node.js: 5.10.0
    Update channel: dev
  • Steps to reproduce:
    1. Pin tab among a group of tabs. Tab shifts left to the pinned area
    2. Use cmd-tab to cycle among tabs

Related #149

@bradleyrichter
Copy link
Contributor

I think this is related: (see lonely pinned tabs)

image

In this case, the tab set should have collapsed to the first set, not stay on an empty #2 set.

Pinned tabs need a different rule set (or more rules) so that they don't intervene with the normal expected tab behaviors.

ayumi added a commit to ayumi/browser-laptop that referenced this issue Jun 15, 2016
ayumi added a commit to ayumi/browser-laptop that referenced this issue Jun 15, 2016
@bbondy bbondy added this to the 0.10.4dev milestone Jun 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants