Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab doesn't stop loading indicator when opening a torrent in tor private tab #14472

Closed
srirambv opened this issue Jun 20, 2018 · 3 comments
Closed

Tab doesn't stop loading indicator when opening a torrent in tor private tab #14472

srirambv opened this issue Jun 20, 2018 · 3 comments
Assignees
@diracdeltas @jumde
Labels
0.23.x issue first seen in 0.23.x bug feature/tor feature/torrent QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jun 20, 2018 •
edited by bsclifton
Loading

Test plan

See #14529

Description

Tab doesn't stop loading indicator when opening a torrent in tor private tab

Steps to Reproduce

  1. Open https://webtorrent.io/free-torrents in a private tor tab
  2. Click on magnet/torrent in the same tab, shows error message, page load indicator keeps going and URL bar progress indicator gets stuck
  3. Open magnet/torrent link in a new tab, shows error message
  4. Dismiss error message, tab keeps trying to load, URL bar progress indicator gets stuck instead of closing the tab after dismissing the message

Actual result:
14374

Expected result:
Should stop loading the page when the error message is shown. Should close the tab after user dismiss the notification.

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

#13063 #14374
@srirambv srirambv added this to the 0.24.x (Developer Channel) milestone Jun 20, 2018
@srirambv srirambv mentioned this issue Jun 22, 2018
Closed
@diracdeltas
Copy link
Member

i have a quick fix for this

@diracdeltas diracdeltas self-assigned this Jun 22, 2018
diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
fix tor-related webtorrent issues
239ea29 
* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
@diracdeltas diracdeltas mentioned this issue Jun 22, 2018
Merged
10 tasks
@bsclifton
Copy link
Member

Fixed with #14529

bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
fix tor-related webtorrent issues
e5f0724 
* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
This was referenced Jun 25, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 25, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
fix tor-related webtorrent issues
32fc8ef 
* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
fix tor-related webtorrent issues
2fc6f3d 
* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
fix tor-related webtorrent issues
291ffaf 
* re-enable webtorrent in private tabs
* stop page loading indicator after torrent warning is shown in a tor
tab

fix #14472
fix #14524

Test Plan:
1. open brave and make sure webtorrent is enabled
2. go to https://webtorrent.io/torrents/sintel.torrent in a private tab.
   it should load webtorrent.
3. go to https://webtorrent.io/torrents/sintel.torrent in a tor tab. it
   should show a privacy warning.
4. click 'ok'. the page loading indicator should stop.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

@jumde jumde

Labels
0.23.x issue first seen in 0.23.x bug feature/tor feature/torrent QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@diracdeltas @jumde @bsclifton @srirambv @LaurenWags @btlechowski