Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix UGP claim related text to help user understand grant may be expiring #14229

Closed
mandar-brave opened this issue May 24, 2018 · 1 comment
Closed

Fix UGP claim related text to help user understand grant may be expiring #14229

mandar-brave opened this issue May 24, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x Release 5 ...

Comments

@mandar-brave
Copy link

mandar-brave commented May 24, 2018 •
edited by NejcZdovc
Loading

Test plan

defined in #14251 (comment)

Issue hasnt been filed yet
Duplicate was filed at https://github.com/brave/internal/issues/341 and recreating here and closing 341

Description

Steps to Reproduce

  1. Users accept grants
  2. Forget that grants have 90 days expiry
  3. During expiration or after contribute BAT to realize BAT has disappeared from balance

Actual result:
See user feedback from reddit

  • confusing states of contribution
  • confusing balances (BAT is missing but statement shows differently)

Expected result:

  • need to explicitly ensure that users know BAT has an expiration timetable
  • and adjust balance to differentiate between BAT grants and other (with expiry dates called out)

Reproduces how often:
100% o ftime

Brave Version

about:brave info:

Reproducible on current live release:

Yes

Additional Information

Recommended fixes via attached files
image 1

image 2

@NejcZdovc @bradleyrichter @evq @davidtemkin
@NejcZdovc NejcZdovc self-assigned this May 24, 2018
@NejcZdovc NejcZdovc added this to the 0.22.x Release 5 milestone May 24, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
8a0ac31 
Resolves brave#14229

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 25, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
80cd075 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
6a80158 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
784e4b8 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
5cbf023 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
451eb83 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
b3d7dad 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
0a08085 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 25, 2018
@NejcZdovc
Adds new balance breakdown
80d48ad 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 28, 2018
@NejcZdovc
Adds new balance breakdown
a0d55ef 
Resolves brave#14229

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue May 28, 2018
@NejcZdovc
Merge pull request #14251 from NejcZdovc/feature/#14229-breakdown
9713445 
Adds balance breakdown
NejcZdovc added a commit that referenced this issue May 28, 2018
@NejcZdovc
Merge pull request #14251 from NejcZdovc/feature/#14229-breakdown
d037f07 
Adds balance breakdown
NejcZdovc added a commit that referenced this issue May 28, 2018
@NejcZdovc
Merge pull request #14251 from NejcZdovc/feature/#14229-breakdown
50b39e0 
Adds balance breakdown
@btlechowski
Copy link
Contributor

btlechowski commented May 29, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.22.722 1dde2a2
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Windows x64 using

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

This was referenced May 30, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

No branches or pull requests
5 participants
@NejcZdovc @srirambv @LaurenWags @btlechowski @mandar-brave