Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Display error when ledger server is not working #13972

Closed
NejcZdovc opened this issue Apr 30, 2018 · 2 comments
Closed

Display error when ledger server is not working #13972

NejcZdovc opened this issue Apr 30, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 3 ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 30, 2018 •
edited by kjozwiak
Loading

Description

When ledger server is down, we should display notification to users that server is down, so that they know what is doing on.

Steps to Reproduce

  1. Enable payments
  2. Turn off internet
  3. Wait 1min and make sure that you see error in the terminal
  4. turn the internet back on and ensure that the warning modal is dismissed under about:preferences#payments
  5. visit a few websites, YT and Twitch channels and ensure they're being added into the ledger table

Actual result:

image

Expected result:
We should display notification about server down
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 30, 2018
@NejcZdovc NejcZdovc self-assigned this Apr 30, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 30, 2018
@NejcZdovc
Adds server problem overlay
a7e8802 
Resolves brave#13972

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Apr 30, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 30, 2018
@NejcZdovc
Adds server problem overlay
b8aef8d 
Resolves brave#13972

Auditors:

Test Plan:
jasonrsadler pushed a commit that referenced this issue May 1, 2018
Merge pull request #13973 from NejcZdovc/fix/#13972-server
7cc0aef 
Adds server problem overlay
NejcZdovc pushed a commit that referenced this issue May 1, 2018
@NejcZdovc
Merge pull request #13973 from NejcZdovc/fix/#13972-server
084f6e1 
Adds server problem overlay
NejcZdovc pushed a commit that referenced this issue May 1, 2018
@NejcZdovc
Merge pull request #13973 from NejcZdovc/fix/#13972-server
cea9a88 
Adds server problem overlay
This was referenced May 3, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 3, 2018 •
edited by srirambv
Loading

13972

Verified on Mint 18.3 x64 using the following build:

  • 0.22.702 e4a853d
  • Muon: 6.0.7
  • libchromiumcontent: 66.0.3359.139

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2018

@GeetaSarvadnya mind rechecking this? I updated the test cases above. We should check that turning the internet back on correctly dismisses the modal and that websites, YT and Twitch are correctly being added into the ledger table once the internet is turned back on.

@srirambv srirambv mentioned this issue May 8, 2018
Closed
@kjozwiak kjozwiak mentioned this issue May 16, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @NejcZdovc @srirambv @LaurenWags @GeetaSarvadnya