Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dragging pinned tab shows the pin outside the browser window frame #13566

Closed
srirambv opened this issue Mar 22, 2018 · 2 comments
Closed

Dragging pinned tab shows the pin outside the browser window frame #13566

srirambv opened this issue Mar 22, 2018 · 2 comments
Assignees
@petemill
Labels
0.22.x issue first seen in 0.22.x bug feature/pinned-tabs polish Nice to have — usually related to front-end/visual tasks. priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by bsclifton
Loading

Description

Dragging pinned tab shows the pin outside the browser window frame

Test plan / Steps to Reproduce

  1. Clean install 0.22.6
  2. Pin 4-5 tabs
  3. Click and drag one of the pinned tabs, the pinned tab is shown outside the browser window frame

Actual result:
pinnedtab_movement

Expected result:
Should not show outside the frame when dragging the pin

Reproduces how often:

Brave Version

about:brave info:

Brave 0.22.6
V8 6.5.254.36
rev e6ff4ea
Muon 5.1.0
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 65.0.3325.162

Reproducible on current live release:
No

Additional Information

cc: @petemill @bsclifton
@srirambv srirambv added bug polish Nice to have — usually related to front-end/visual tasks. feature/pinned-tabs 0.22.x issue first seen in 0.22.x labels Mar 22, 2018
@srirambv srirambv added this to the 0.22.x (Beta Channel) milestone Mar 22, 2018
@LaurenWags
Copy link
Member

Reproduced on MacOS

@petemill petemill added the priority/P4 Minor loss of function. Workaround usually present. label Mar 26, 2018
petemill added a commit to petemill/browser-laptop that referenced this issue Mar 27, 2018
@petemill
'Tab Mouse' gradient scales to tab size
a4e94a2 
Never wider than the size of the tab, so it does not affect drag bounds.
Fix brave#13566
@petemill petemill mentioned this issue Mar 27, 2018
Merged
10 tasks
This was referenced Mar 28, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 28, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Ubuntu 17.10 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Verified on Win7 x64:

  • 0.22.8: 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.22.x issue first seen in 0.22.x bug feature/pinned-tabs polish Nice to have — usually related to front-end/visual tasks. priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @kjozwiak @bsclifton @srirambv @LaurenWags @btlechowski