Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned and unpinned ledger values are not aligned properly #13024

Closed
srirambv opened this issue Feb 5, 2018 · 2 comments
Closed

Pinned and unpinned ledger values are not aligned properly #13024

srirambv opened this issue Feb 5, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 5, 2018

Description

Pinned and unpinned ledger values are not aligned properly

Steps to Reproduce

  1. Visit few sites and populate ledger table
  2. Pin a few sites
  3. See the awkward alignment of % values

Actual result:
0.22.0
image
0.20.30
image

Expected result:
Should be similar to how it looks on 0.20.30

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.0
rev ac59a52
Muon 5.0.1
libchromiumcontent 64.0.3282.119

Reproducible on current live release:
No

Additional Information
@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks. feature/rewards regression labels Feb 5, 2018
@srirambv srirambv added this to the Triage Backlog milestone Feb 5, 2018
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 6, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 6, 2018
@NejcZdovc
Fixes percentage values alignment
814a338 
Resolves brave#13024

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 6, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 6, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 6, 2018 •
edited
Loading

this was broken in 0.22 branch, particular in #10789

@NejcZdovc NejcZdovc self-assigned this Feb 7, 2018
bsclifton added a commit that referenced this issue Feb 7, 2018
@bsclifton
Merge pull request #13036 from NejcZdovc/hotfix/#13024-polish
50d7d3d 
Fixes percentage values alignment
bsclifton added a commit that referenced this issue Feb 7, 2018
@bsclifton
Merge pull request #13036 from NejcZdovc/hotfix/#13024-polish
4f2bfba 
Fixes percentage values alignment
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.14 f4da855
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
6 participants
@bbondy @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski