Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable auto-include publisher causes existing publishers to be excluded #12621

Closed
srirambv opened this issue Jan 12, 2018 · 5 comments
Closed

Disable auto-include publisher causes existing publishers to be excluded #12621

srirambv opened this issue Jan 12, 2018 · 5 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 12, 2018 •
edited by bsclifton
Loading

Test plan

#12624

Description

Disable auto-include publisher causes existing publishers to be excluded

Steps to Reproduce

  1. Clean install 0.19.133
  2. Enable payments, visit some publishers to add entry in ledger table
  3. Disable auto-include, visit a new site, all entries gets disabled

Actual result:
On 0.19.133
ledgeryt
On 0.19.131
ledgeryt-131

Expected result:
Should not exclude all existing publishers form the table

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.131 0.19.133
rev da2f347 e05a8ef
Muon 4.5.36 4.5.38
libchromiumcontent 63.0.3239.132 63.0.3239.132
V8 6.3.292.49 6.3.292.49
Node.js 7.9.0 7.9.0
Update Channel Release Release
OS Platform Microsoft Windows Microsoft Windows
OS Release 10.0.16299 10.0.16299
OS Architecture x64 x64

Reproducible on current live release:
No

Additional Information

Same behaviour on 0.20.x as well
cc: @NejcZdovc @bridiver @bsclifton
@srirambv srirambv added this to the 0.19.x Hotfix 12 milestone Jan 12, 2018
@NejcZdovc
Copy link
Contributor

This regressed with muon upgrade from .36 to .38

@srirambv srirambv mentioned this issue Jan 12, 2018
Closed
@srirambv
Copy link
Collaborator Author

Same issue on Linux as well
ledger-linux

But with a different(new) profile it wasn't reproduced. Although it did have other publishers listed
image

@NejcZdovc
Copy link
Contributor

ok this is not a new thing it's just timing thing

@NejcZdovc NejcZdovc modified the milestones: 0.19.x Hotfix 12, Triage Backlog Jan 12, 2018
@NejcZdovc
Copy link
Contributor

I still thing that we need to fix it soon, could be quite a problem, so I will add it into 0.20.x

@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.20.x Hotfix 1 Jan 12, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 12, 2018
@NejcZdovc
Fixes include/exclude when updating db
82edcde 
Resolves brave#12621

Auditors:

Test Plan:
@NejcZdovc NejcZdovc self-assigned this Jan 12, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.20.x Hotfix 1, 0.20.x (Beta Channel) Jan 12, 2018
@NejcZdovc NejcZdovc mentioned this issue Jan 12, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 12, 2018
@NejcZdovc
Fixes include/exclude when updating db
07b27fc 
Resolves brave#12621

Auditors:

Test Plan:
@LaurenWags
Copy link
Member

Reproduced on MacOS with 0.19.133

bsclifton added a commit that referenced this issue Jan 16, 2018
@bsclifton
Merge pull request #12624 from NejcZdovc/hotfix/#12621-exclude
18040b9 
Fixes include/exclude when updating db
bsclifton added a commit that referenced this issue Jan 16, 2018
@bsclifton
Merge pull request #12624 from NejcZdovc/hotfix/#12621-exclude
faa928b 
Fixes include/exclude when updating db
bsclifton added a commit that referenced this issue Jan 16, 2018
@bsclifton
Merge pull request #12624 from NejcZdovc/hotfix/#12621-exclude
de5970f 
Fixes include/exclude when updating db
This was referenced Jan 24, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags