Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New windows now open instantly #12437

Closed
petemill opened this issue Dec 29, 2017 · 1 comment
Closed

New windows now open instantly #12437

petemill opened this issue Dec 29, 2017 · 1 comment
Assignees
@petemill
Labels
initiative/perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x (Release C...

Comments

@petemill
Copy link
Member

petemill commented Dec 29, 2017 •
edited by LaurenWags
Loading

Test Plan

#12438

As part of the performance initiative, it has been determined that a task to attack is the time a user must wait for new windows to be created and rendered, before creating / viewing the tab(s) for that window.

Adding timing to measure this from window creation to when react has finished rendering, it seems to take 1s to render a window (+1s/-0.5s depending on system).
@petemill petemill added this to the 0.21.x (Developer Channel) milestone Dec 29, 2017
@petemill petemill self-assigned this Dec 29, 2017
petemill added a commit that referenced this issue Dec 29, 2017
@petemill
Create a Buffer Window, which is used consistently to open new window…
67ad847 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
@petemill petemill mentioned this issue Dec 29, 2017
Merged
10 tasks
petemill added a commit that referenced this issue Dec 29, 2017
@petemill
Create a Buffer Window, which is used consistently to open new window…
230c149 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
petemill added a commit that referenced this issue Jan 4, 2018
@petemill
Create a Buffer Window, which is used consistently to open new window…
6ab1e69 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
petemill added a commit that referenced this issue Jan 4, 2018
@petemill
Create a Buffer Window, which is used consistently to open new window…
9205055 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
petemill added a commit that referenced this issue Jan 5, 2018
@petemill
Create a Buffer Window, which is used consistently to open new window…
27f7bbd 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
@petemill petemill changed the title New windows wait for render before showing Windows should load more instantly Feb 1, 2018
petemill added a commit that referenced this issue Feb 8, 2018
@petemill
Create a Buffer Window, which is used consistently to open new window…
3935587 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
bsclifton pushed a commit that referenced this issue Feb 15, 2018
@petemill @bsclifton
Create a Buffer Window, which is used consistently to open new window…
2d8b111 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
petemill added a commit that referenced this issue Feb 16, 2018
@petemill
Create a Buffer Window, which is used consistently to open new window…
0cb6385 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix #12437
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@petemill @ryanml
Create a Buffer Window, which is used consistently to open new window…
ab3959a 
…s more instantly

A buffer window is created at startup, and any time a previous buffer window is detached in order to be utilized as a real window.
This type of window is not shown and has no tabs (pinned or non-pinned) until it is shown.
State is not persisted for Buffer Windows until they are utilized as real windows.

A new command-line flag is introduced: '--debug-window-events' which shows logging around Buffer Window creation and utilization, as well as all other window events. No additional logging should be present without this flag.

Fix brave#12437
@LaurenWags
Copy link
Member

LaurenWags commented Mar 26, 2018 •
edited by kjozwiak
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Windows 7 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Mint 18.2 Sonya x64 using the following build:

  • 0.22.11 56de947
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

@kjozwiak kjozwiak mentioned this issue Mar 28, 2018
Closed
@bsclifton bsclifton changed the title Windows should load more instantly New windows should load more instantly Mar 29, 2018
@bsclifton bsclifton changed the title New windows should load more instantly New windows now open instantly Mar 29, 2018
@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
initiative/perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
4 participants
@petemill @kjozwiak @LaurenWags @btlechowski