This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Folders from other channels need to be disregarded when building package #11939
Assignees
Milestone
Comments
darkdh
added a commit
that referenced
this issue
Nov 16, 2017
fix #11939 Auditors: @bsclifton Test Plan: (Test on all platforms) 1. CHANNEL=beta npm run build-package 2. CHANNEL=beta npm run build-installer 3. CHANNEL=nightly npm run build-package 4. Note the size of the resources/app.asar (should be ~266 megs, not > 1GB)
8 tasks
bsclifton
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 6 (Release channel)
This was referenced Nov 23, 2017
|
The installers size looks normal. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#11991 (comment)
Description
While on the same machine, if you build a package for
betachannel and then one fornightly, thenightlypackage will be significantly larger. This is because thebuild-packagestep will pack thebetacontent into the nightly's ASAR fileA fix for this issue was introduced with #10552, but it has a side-effect of causing this issue:
#11799
In the 0.19.x branch, the ignorePaths was removed with 41dc7cf
Steps to Reproduce
CHANNEL=beta npm run build-packageCHANNEL=beta npm run build-installerCHANNEL=nightly npm run build-packageresources/app.asar(should be ~266 megs, not > 1 GB)Brave Version
0.20.x and newer (when packaging)
Reproducible on current live release:
No
Additional Information
This should be fixable by either hardcoding the names or creating a stronger regex match (which matches only the builds, not libraries like
brave-crypto)The text was updated successfully, but these errors were encountered: