Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

APP_WINDOW_CLOSED action is never fired #11859

Closed
petemill opened this issue Nov 8, 2017 · 2 comments · Fixed by #12422
Closed

APP_WINDOW_CLOSED action is never fired #11859

petemill opened this issue Nov 8, 2017 · 2 comments · Fixed by #12422
Assignees
@petemill
Labels
bug priority/P4 Minor loss of function. Workaround usually present. QA/no-qa-needed release-notes/include
Milestone
0.20.x (Release C...

Comments

@petemill
Copy link
Member

petemill commented Nov 8, 2017

Description

When closing a window, this action is not called, therefore state / cache cleanup is not happening. I haven't personally invesitgated yet, so I don't know when in the window closing lifecycle it was supposed to be closed.

Brave Version

about:brave info:
master (0.22.0)
@petemill petemill added the bug label Nov 8, 2017
@petemill petemill added this to the Triage Backlog milestone Nov 8, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 9, 2017 •
edited
Loading

This cal was removed in this commit 22a1c33#diff-5fdd9f55221fe32ba22dea6484d4135cL24

cc @bbondy

@bbondy bbondy modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Nov 9, 2017
@petemill petemill self-assigned this Nov 29, 2017
@alexwykoff alexwykoff added priority/P4 Minor loss of function. Workaround usually present. needs-info Another team member needs information from the PR/issue opener. labels Nov 29, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Dec 28, 2017
@petemill
Reinstate call to cleanup window data from state and static reference…
947c213 
… when window has been closed

Fix brave#11859
@petemill petemill mentioned this issue Dec 28, 2017
Merged
10 tasks
@bsclifton bsclifton added QA/test-plan-required and removed needs-info Another team member needs information from the PR/issue opener. labels Dec 28, 2017
@bsclifton
Copy link
Member

I've manually tested this and it also has an automated test 👍

@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
bug priority/P4 Minor loss of function. Workaround usually present. QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Reinstate call to cleanup window data petemill/browser-laptop
6 participants
@petemill @bbondy @alexwykoff @luixxiul @bsclifton @NejcZdovc