Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Non focussed windows still have the title bar color of a focussed window #1156

Closed
tetrode opened this issue Mar 23, 2016 · 8 comments
Closed
Labels
design A design change, especially one which needs input from the design team. OS/Windows

Comments

@tetrode
Copy link

tetrode commented Mar 23, 2016

Scenario:

  • start brave
  • open a new window

Expected

  • one window (the focussed one) has the blue window title bar appearance of a focussed window, the other one has the grey window title bar appearance
    Actual
  • both windows have a blue bar

Environment

  • Windows 7, classic view.
@bradleyrichter
Copy link
Contributor

@tetrode if you have a chance, could you post a screen shot please?

@tetrode
Copy link
Author

tetrode commented Mar 23, 2016

Screenshot here: http://imgur.com/LAFhzl1 after pressing Ctrl+N a couple of times

@bradleyrichter
Copy link
Contributor

ah ha! Thanks @tetrode

This will go away as soon as we can fix an Electron "bug" that allows us to remove that extra title bar like Chrome does.

@bridiver If that is too far out, then we should try to fix this...

@tetrode
Copy link
Author

tetrode commented Mar 23, 2016

@bradleyrichter Are you planning to change the title bar / browser URL / bookmarks / tabs area?

For me this is using too much space compared to other browsers. WRT real estate, IE, FF, Chome are doing much better, using only halve of the area Brave is using

@bradleyrichter
Copy link
Contributor

I recently reduced the total stackup and at least on Mac OS, we are now 2 pixels shorter than Chrome, and much shorter than FX.

You might be seeing the extra title bar on Windows which we are trying to remove soon?

mac:

image

Would you mind posting a similar screen shot from Win7 or 8?

@tetrode
Copy link
Author

tetrode commented Mar 24, 2016

Here you are

[image: Inline image 1]

Best

.

On Thu, Mar 24, 2016 at 12:32 AM, Brad Richter notifications@github.com
wrote:

I recently reduced the total stackup and at least on Mac OS, we are now 2
pixels shorter than Chrome, and much shorter than FX.

You might be seeing the extra title bar on Windows which we are trying to
remove soon?

mac:

[image: image]
https://cloud.githubusercontent.com/assets/13509546/14004052/8ccc3d2c-f114-11e5-86bb-bc07aa607d2e.png

Would you mind posting a similar screen shot from Win7 or 8?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1156 (comment)

@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team. needs-info Another team member needs information from the PR/issue opener. labels Jun 17, 2016
@bsclifton
Copy link
Member

Would be good to retest when #3036 is resolved (coming soon)

@bsclifton
Copy link
Member

This is now fixed and will be released w/ 0.12.6 😄 (specifically was resolved with PR #4856)

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Nov 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. OS/Windows
Projects
None yet
Development

No branches or pull requests

5 participants