This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 970
We should display unconfirmed funds to let users know balance is not 0 #11334
Labels
Milestone
Comments
Assigned @bradleyrichter- this won't make the 0.19.x release, but would still be nice to do. We'd just need a mock up of how it should look and then we can assign a priority / figure out where this should land. cc: @zentagonist |
Is this no longer working?
… On Oct 6, 2017, at 8:16 PM, eV (㋎) ***@***.***> wrote:
Just to add here, the way this was displayed in the BTC proof of concept:
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
yes, this did not appear for me when I converted BTC -> BAT, it always said "your new wallet is ready" |
I think that we don't need any new flows. We just need to fix existing flow |
Awesome, thanks for confirming 😄 Since we already had something in place, this is a regression |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Oct 9, 2017
Resolves brave#11334 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Oct 9, 2017
Resolves brave#11334 Auditors: Test Plan:
NejcZdovc
added a commit
that referenced
this issue
Oct 9, 2017
Resolves #11334 Auditors: Test Plan:
NejcZdovc
added a commit
that referenced
this issue
Oct 9, 2017
Resolves #11334 Auditors: Test Plan:
This was referenced Oct 9, 2017
Message displays, but there is a delay. Per @NejcZdovc once we receive data about funds this message is displayed. |
The message does not disappear once the funds are received: #11439 |
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Resolves brave#11334 Auditors: Test Plan:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See below
Description
While launching and trying the BAT Mercury release with my personal profile, I noticed it took a while for funds to make their way into the account (~15-20 minutes).
After the confirmation process finished, it did show as expected:
![screen shot 2017-10-06 at 4 59 20 pm](https://user-images.githubusercontent.com/4733304/31302989-782e0e56-aabb-11e7-84b6-e97793f36bb7.png)
Steps to Reproduce
Actual result:
Balance is 0
Expected result:
Balance should be 0, but we should also show "Funds are still being verified. Please be patient" and we can also show the unconfirmed balance if we'd like.
Reproduces how often: 100%
Brave Version
about:brave info:
Reproducible on current live release:
no
Additional Information
The text was updated successfully, but these errors were encountered: