Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

We should display unconfirmed funds to let users know balance is not 0 #11334

Closed
bsclifton opened this issue Oct 7, 2017 · 9 comments
Closed

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 7, 2017

Test plan

See below


Description

While launching and trying the BAT Mercury release with my personal profile, I noticed it took a while for funds to make their way into the account (~15-20 minutes).

screen shot 2017-10-06 at 4 34 57 pm

After the confirmation process finished, it did show as expected:
screen shot 2017-10-06 at 4 59 20 pm

Steps to Reproduce

  1. Have a wallet created in 0.18.x with funds
  2. Download the latest (not yet available) BAT Mercury build
  3. Install and go to payments tab

Actual result:
Balance is 0

Expected result:
Balance should be 0, but we should also show "Funds are still being verified. Please be patient" and we can also show the unconfirmed balance if we'd like.

Reproduces how often: 100%

Brave Version

about:brave info:

Reproducible on current live release:
no

Additional Information

@bsclifton bsclifton added feature/rewards needs-mockup A feature which needs design mockup to be implemented. labels Oct 7, 2017
@bsclifton
Copy link
Member Author

Assigned @bradleyrichter- this won't make the 0.19.x release, but would still be nice to do. We'd just need a mock up of how it should look and then we can assign a priority / figure out where this should land.

cc: @zentagonist

@evq
Copy link
Member

evq commented Oct 7, 2017

Just to add here, the way this was displayed in the BTC proof of concept:
oldpending

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Oct 7, 2017 via email

@evq
Copy link
Member

evq commented Oct 7, 2017

yes, this did not appear for me when I converted BTC -> BAT, it always said "your new wallet is ready"

@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Oct 9, 2017
@NejcZdovc NejcZdovc removed the needs-mockup A feature which needs design mockup to be implemented. label Oct 9, 2017
@NejcZdovc
Copy link
Contributor

I think that we don't need any new flows. We just need to fix existing flow

@NejcZdovc NejcZdovc self-assigned this Oct 9, 2017
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 9, 2017

this is how it will look now
image

@bsclifton
Copy link
Member Author

Awesome, thanks for confirming 😄 Since we already had something in place, this is a regression

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 9, 2017
Resolves brave#11334

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 9, 2017
Resolves brave#11334

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Oct 9, 2017
NejcZdovc added a commit that referenced this issue Oct 9, 2017
Resolves #11334

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Oct 9, 2017
Resolves #11334

Auditors:

Test Plan:
@LaurenWags
Copy link
Member

Message displays, but there is a delay. Per @NejcZdovc once we receive data about funds this message is displayed.

@hugobuddel
Copy link
Contributor

The message does not disappear once the funds are received: #11439

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Resolves brave#11334

Auditors:

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.