Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor drag and drop bookmarks to be done in store #11226

Closed
bbondy opened this issue Oct 1, 2017 · 2 comments
Closed

Refactor drag and drop bookmarks to be done in store #11226

bbondy opened this issue Oct 1, 2017 · 2 comments
Assignees
@cezaraugusto
Labels
feature/bookmarks initiative/perf misc/drag-and-drop stale

Comments

@bbondy
Copy link
Member

bbondy commented Oct 1, 2017 •
edited
Loading

This is not working properly after the Redux refactor. There was a temporary fix to hold us over in 0.19.x
@bbondy bbondy added this to the 0.21.x (Nightly Channel) milestone Oct 1, 2017
@bbondy bbondy self-assigned this Oct 1, 2017
bbondy added a commit that referenced this issue Oct 1, 2017
@bbondy
Support drag and drop urlbar icon onto bookmark folders
7671ae9 
Fix #11180

This mostly just reverts a subset of:
d82f171

This is only for 0.19.x and 0.20.x

Master can get a better fix so tests and refactoring will be done in:
#11226

Since the tests would not be valid past 0.20.x I'm not covering any new
0.19.x and 0.20.x only tests here.  Also we don't have drag and drop
under tets at all.  In master with the refactor since we have bookmark
toolbar width in state we'll be able to do everything in the reducer and so also be able
to add tests.

Auditors: @bsclifton
bbondy added a commit that referenced this issue Oct 1, 2017
@bbondy
Support drag and drop urlbar icon onto bookmark folders
602ee6f 
Fix #11180

This mostly just reverts a subset of:
d82f171

This is only for 0.19.x and 0.20.x

Master can get a better fix so tests and refactoring will be done in:
#11226

Since the tests would not be valid past 0.20.x I'm not covering any new
0.19.x and 0.20.x only tests here.  Also we don't have drag and drop
under tets at all.  In master with the refactor since we have bookmark
toolbar width in state we'll be able to do everything in the reducer and so also be able
to add tests.

Auditors: @bsclifton
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@cezaraugusto cezaraugusto self-assigned this Dec 21, 2017
@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jan 9, 2018 •
edited
Loading

removing release/blocking label as all boomark dnd features are working now dnd/bm issues are being covered separately. please add it back if I'm wrong.

will leave it open as it's still a better take than what we have but shouldn't block a release.

RN we have other standalone issues with related bugs like #12484, #12481, #9939, #9517 (refactor)

cezaraugusto added a commit that referenced this issue Jan 15, 2018
@cezaraugusto
move bookmark drop logic in bm toolbar to the store
653ab1d 
-
this allow us to add more precise tests
fix #11226
@bsclifton bsclifton modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Jan 19, 2018
@bsclifton bsclifton modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 13, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x

@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
@bsclifton bsclifton modified the milestones: 0.23.x (Nightly Channel), Completed work Feb 28, 2018
@bsclifton bsclifton added the stale label May 1, 2018
@bsclifton bsclifton removed this from the Completed work milestone May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/bookmarks initiative/perf misc/drag-and-drop stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @cezaraugusto @bsclifton