Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

deleting history entries should remove them from 'History' menu #10328

Closed
diracdeltas opened this issue Aug 7, 2017 · 0 comments · Fixed by #10331
Closed

deleting history entries should remove them from 'History' menu #10328

diracdeltas opened this issue Aug 7, 2017 · 0 comments · Fixed by #10331
Assignees
@diracdeltas
Labels
bug feature/history privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Aug 7, 2017 •
edited by luixxiul
Loading

Test plan

#10331 (comment)

#8761 (comment) is broken on 0.21.x but not 0.19 or 0.20; this is because #10069 was reverted on 0.21.x due to conflicts with #10136.

STR:

  1. open a tab, go to any site
  2. close the tab. notice that the site appears in the History menu.
  3. go to about:history and delete the visited site.
  4. it still appears in the History menu
@diracdeltas diracdeltas self-assigned this Aug 7, 2017
@diracdeltas diracdeltas modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Aug 7, 2017
@luixxiul luixxiul added the bug label Aug 7, 2017
diracdeltas added a commit that referenced this issue Aug 8, 2017
@diracdeltas
fix deleting history entry from History menu
a8650d4 
fix #10328

Test Plan:
open a tab, go to any site
close the tab. notice that the site appears in the History menu.
go to about:history and delete the visited site.
it should disappear from the History menu
@diracdeltas diracdeltas mentioned this issue Aug 8, 2017
Merged
8 tasks
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@diracdeltas @dfperry5
fix deleting history entry from History menu
fec4e1b 
fix brave#10328

Test Plan:
open a tab, go to any site
close the tab. notice that the site appears in the History menu.
go to about:history and delete the visited site.
it should disappear from the History menu
@diracdeltas diracdeltas mentioned this issue Sep 20, 2017
Merged
8 tasks
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/history privacy QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix deleting history entry from History menu brave/browser-laptop
6 participants
@diracdeltas @bbondy @luixxiul @bsclifton @srirambv @LaurenWags