Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

make sure we pass basic Electron security audit #10240

Closed
diracdeltas opened this issue Aug 1, 2017 · 2 comments · Fixed by #10242
Closed

make sure we pass basic Electron security audit #10240

diracdeltas opened this issue Aug 1, 2017 · 2 comments · Fixed by #10242
Assignees
@diracdeltas
Labels
QA/no-qa-needed release-notes/include sec-low security
Milestone
0.20.x (Release C...

Comments

@diracdeltas
Copy link
Member

Most of https://doyensec.com/resources/us-17-Carettoni-Electronegativity-A-Study-Of-Electron-Security-wp.pdf does not apply to Muon but we should go through it anyway and make sure we don't have any security gaps.
@diracdeltas diracdeltas self-assigned this Aug 1, 2017
@diracdeltas diracdeltas added this to the 0.20.x (Developer Channel) milestone Aug 1, 2017
diracdeltas added a commit that referenced this issue Aug 1, 2017
@diracdeltas
remove webSecurity:false in webPreferences
def7253 
and add some comments for security-sensitive code

fix #10240
@diracdeltas diracdeltas mentioned this issue Aug 1, 2017
Merged
8 tasks
diracdeltas added a commit that referenced this issue Aug 3, 2017
@diracdeltas
remove webSecurity:false in webPreferences
7ef82be 
and add some comments for security-sensitive code

fix #10240
@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 7, 2017
diracdeltas added a commit that referenced this issue Aug 15, 2017
@diracdeltas
remove webSecurity:false in webPreferences
4992f99 
and add some comments for security-sensitive code

fix #10240
@NejcZdovc NejcZdovc modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Aug 15, 2017
@alexwykoff
Copy link
Contributor

@diracdeltas how is this looking for 0.20?

@diracdeltas
Copy link
Member Author

@alexwykoff waiting on @bridiver review

diracdeltas added a commit that referenced this issue Sep 1, 2017
@diracdeltas
remove webSecurity:false in webPreferences
019f85b 
and add some comments for security-sensitive code

fix #10240
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/no-qa-needed release-notes/include sec-low security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

remove webSecurity:false in webPreferences brave/browser-laptop
4 participants
@diracdeltas @alexwykoff @luixxiul @NejcZdovc