Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

no tab close icon is shown for the active tab on Windows #10123

Closed
cezaraugusto opened this issue Jul 25, 2017 · 6 comments · Fixed by #10691
Closed

no tab close icon is shown for the active tab on Windows #10123

cezaraugusto opened this issue Jul 25, 2017 · 6 comments · Fixed by #10691
Assignees
@cezaraugusto
Labels
feature/tabsbar OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jul 25, 2017 •
edited by luixxiul
Loading

Test plan

#10691 (comment)

Active tab should show close icon always on hover for default tabs and always visible for small tabs.

Reported by @bbondy and seems like a DPI issue/Windows specific. May be related to #9779 and across platforms. Moving both to 0.18.x as this makes tabs almost unusable.
@cezaraugusto cezaraugusto added this to the 0.18.x (Beta Channel) milestone Jul 25, 2017
@bbondy
Copy link
Member

bbondy commented Jul 25, 2017

I think it will be fixed by the same fix as #9872 and that fix will also help some users that have tear off sensitivity problems.

@bbondy bbondy modified the milestones: 0.19.x (Developer Channel), 0.18.x (Beta Channel) Jul 25, 2017
@alexwykoff alexwykoff assigned NejcZdovc and unassigned NejcZdovc Aug 8, 2017
@bsclifton
Copy link
Member

@bbondy is there a specific DPI you're using for this? I'm not able to reproduce the issue at 125% (maybe I'm not doing the correct steps).

What I'm trying:

  • Tab page size is set to 20
  • I open lots of tabs
  • switch back to tab page 1
  • resize the window to be super small

This is using 0.19.x and Muon 4.4.x

@bbondy
Copy link
Member

bbondy commented Aug 18, 2017

I see this on my surface book and desktop which are both set to 150% DPI

@bsclifton
Copy link
Member

OK reproduced 😄 Here are the steps!

  1. Set tab page to 20
  2. Maximize window
  3. Create enough tabs that you get a second page (21 tabs)
  4. switch back to tab page 1
  5. click one of the tabs to make it the active tab
  6. Hover over the other tabs and notice there is no X button
  7. Close a few tabs- enough that you see the tab breakpoint size change
  8. Hover over tabs and X now shows again

@cezaraugusto cezaraugusto self-assigned this Aug 20, 2017
@cezaraugusto
Copy link
Contributor Author

after above comment this seems related to tab breakpoints so I'm taking this one

@cezaraugusto cezaraugusto modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Aug 22, 2017
cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@jenn-rhim
Copy link

It happens consistently once the tab count reaches to 16 on my Mac laptop (osX 10.12.6).

screen shot 2017-09-12 at 11 02 40 am

@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
23fcc08 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
7c58204 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
2427327 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
94ba1a1 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
UI bug fixing
321281b 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
UI bug fixing
ac96632 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
35 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/tabsbar OS/Windows QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
7 participants
@bbondy @luixxiul @jenn-rhim @cezaraugusto @bsclifton @NejcZdovc @srirambv