This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
pinned tab disappears by reordering and unpinning #10037
Labels
Milestone
Comments
the bug can be reproduced with any sites, including about pages |
I noticed a similar bug. I just tried to pin a tab and it disappears, when I have five other pinned tabs. I then unpinned a tab (the far right pinned tab) and two of the pinned tabs next to it disappeared. I was then able to pin a tab. I guess I'll have to not reorder pinned tabs until this bug is fixed. |
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 16, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 16, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
8 tasks
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 26, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 27, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. In many situations, when pinning a tab, all previously pinned tabs would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 27, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Aug 28, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
bsclifton
pushed a commit
to petemill/browser-laptop
that referenced
this issue
Aug 29, 2017
…inned tab Fix brave#3760, fix brave#9635, fix brave#10037, fix brave#10510, and possibly addresses brave#10117 The previous code resulted in tabs being marked as no longer required to be pinned, and closed prematurely. This mostly occured after a pinned-tab reordering - afterwards, when pinning or unpinning a tab, all previously pinned tabs with a new order would be closed. Sometimes this appeared like a 'crash' when the window closed because all the tabs had been (undesirably) closed.
This was referenced Dec 20, 2017
35 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#10531 (comment)
Describe the issue you encountered: pinned tab disappears by reordering and unpinning
Platform (Win7, 8, 10? macOS? Linux distro?): Debian
Brave Version (revision SHA): 0.17.17
Steps to reproduce:
Actual result: twitter, the other pinned tab, disappears
Expected result: it should not disapper
Any related issues:
The text was updated successfully, but these errors were encountered: