Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Fix change of having last tab detached destroyed
Browse files Browse the repository at this point in the history
Auditors: @bridiver

Fix #10436

This is covered by a test already but the bug is a very intermittent race
condition.
  • Loading branch information
bbondy committed Aug 31, 2017
1 parent 9100139 commit e92fa09
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/browser/tabs.js
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ const api = {
// webcontents is still the embedder.
const tabValue = getTabValue(tabId)
const windowId = tabValue.get('windowId')
tab.once('will-attach', () => {
tab.once('did-attach', () => {
appActions.tabStripEmpty(windowId)
})
})
Expand Down

0 comments on commit e92fa09

Please sign in to comment.