Tab should cycle between results

Fix #5878 Auditors: @bsclifton
brave · May 18, 2017 · d1607d8 · d1607d8
1 parent 5187733
commit d1607d8
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/app/renderer/components/navigation/urlBar.js b/app/renderer/components/navigation/urlBar.js
@@ -199,7 +199,14 @@ class UrlBar extends React.Component {
         this.hideAutoComplete()
         break
       case KeyCodes.TAB:
-        this.hideAutoComplete()
+        if (this.shouldRenderUrlBarSuggestions) {
+          if (e.shiftKey) {
+            windowActions.previousUrlBarSuggestionSelected()
+          } else {
+            windowActions.nextUrlBarSuggestionSelected()
+          }
+          e.preventDefault()
+        }
         break
       default:
         this.keyPressed = true
@@ -315,6 +322,7 @@ class UrlBar extends React.Component {
     switch (e.keyCode) {
       case KeyCodes.UP:
       case KeyCodes.DOWN:
+      case KeyCodes.TAB:
       case KeyCodes.ESC:
         return
     }

diff --git a/test/lib/brave.js b/test/lib/brave.js
@@ -114,6 +114,7 @@ var exports = {
     UP: '\ue013',
     PAGEDOWN: '\uE00F',
     END: '\uE010',
+    TAB: '\ue004',
     NULL: '\uE000'
   },
 

diff --git a/test/navbar-components/urlBarTest.js b/test/navbar-components/urlBarTest.js
@@ -265,6 +265,21 @@ describe('urlBar tests', function () {
       })
     })
 
+    describe('highlight suggestions with tab', function () {
+      it('autofills from selected suggestion', function * () {
+        // now type something
+        yield this.app.client
+          .keys('https://br')
+          .waitForInputText(urlInput, 'https://brave.com')
+          // hit down
+          .keys(Brave.keys.TAB)
+          .waitForInputText(urlInput, 'https://brave.com/test')
+          // hit up
+          .keys(Brave.keys.SHIFT + Brave.keys.TAB)
+          .waitForInputText(urlInput, 'https://brave.com')
+      })
+    })
+
     describe('highlight suggestions', function () {
       it('autofills from selected suggestion', function * () {
         // now type something