Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Replaced ids with className (for more consistency)
Browse files Browse the repository at this point in the history
Auditors: @bsclifton

Test Plan: make sure styling of about:payments is not broken and tests pass
  • Loading branch information
Suguru Hirahara committed Dec 6, 2016
1 parent 9bdb37a commit 95c6ddc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
8 changes: 4 additions & 4 deletions js/about/preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ class LedgerTable extends ImmutableComponent {
if (!this.synopsis || !this.synopsis.size) {
return null
}
return <div id='ledgerTable'>
return <div className='ledgerTable'>
<SortableTable
headings={['rank', 'publisher', 'include', 'views', 'timeSpent', 'percentage']}
defaultHeading='rank'
Expand Down Expand Up @@ -473,7 +473,7 @@ class BitcoinDashboard extends ImmutableComponent {
render () {
window.addEventListener('message', this.onMessage.bind(this), false)
var emptyDialog = true
return <div id='bitcoinDashboard'>
return <div className='bitcoinDashboard'>
{
this.props.bitcoinOverlayVisible
? <ModalOverlay title={'bitcoinBuy'} content={this.bitcoinOverlayContent} customTitleClasses={'coinbaseOverlay'} emptyDialog={emptyDialog} onHide={this.props.hideOverlay.bind(this)} />
Expand Down Expand Up @@ -1224,7 +1224,7 @@ class PaymentsTab extends ImmutableComponent {
<td>
<SettingsList>
<SettingItem>
<select className='form-control' id='fundsSelectBox'
<select className='form-control fundsSelectBox'
value={getSetting(settings.PAYMENTS_CONTRIBUTION_AMOUNT,
this.props.settings)}
onChange={changeSetting.bind(null, this.props.onChangeSetting, settings.PAYMENTS_CONTRIBUTION_AMOUNT)} >
Expand Down Expand Up @@ -1270,7 +1270,7 @@ class PaymentsTab extends ImmutableComponent {
}

render () {
return <div id='paymentsContainer'>
return <div className='paymentsContainer'>
{
this.enabled && this.props.addFundsOverlayVisible
? <ModalOverlay title={this.overlayTitle} content={this.overlayContent} onHide={this.props.hideOverlay.bind(this, 'addFunds')} />
Expand Down
8 changes: 4 additions & 4 deletions less/about/preferences.less
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ table.sortableTable {
}
}

#ledgerTable {
.ledgerTable {

tr {
th,
Expand Down Expand Up @@ -562,7 +562,7 @@ div.nextPaymentSubmission {
}


#paymentsContainer {
.paymentsContainer {
@walletTableData: 235px + 30px; // .walletBar td (min-width + padding)
@barMargin: 15px 0 30px;

Expand Down Expand Up @@ -697,7 +697,7 @@ div.nextPaymentSubmission {
.settingsListContainer {
margin-bottom: 0;

#fundsSelectBox {
.fundsSelectBox {
width: auto;
}
}
Expand Down Expand Up @@ -824,7 +824,7 @@ div.nextPaymentSubmission {
}
}

#bitcoinDashboard {
.bitcoinDashboard {

.modal {
.qrcodeOverlay {
Expand Down
6 changes: 3 additions & 3 deletions test/lib/selectors.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ module.exports = {
walletSwitch: '.enablePaymentsSwitch .switchBackground',
addFundsButton: '.addFunds',
advancedSettings: '.advancedSettings',
fundsSelectBox: '#fundsSelectBox',
fundsSelectBox: '.fundsSelectBox',
paymentsStatus: '.walletStatus',
ledgerTable: '#ledgerTable',
bitcoinDashboard: '#bitcoinDashboard',
ledgerTable: '.ledgerTable',
bitcoinDashboard: '.bitcoinDashboard',
modalCloseButton: 'button.close',
coinbaseBuyButton: '[data-l10n-id="add"]',
paymentQRCode: '[title="Brave wallet QR code"]',
Expand Down

0 comments on commit 95c6ddc

Please sign in to comment.