Initial work done for #2106

- Add settings for new tab behaviour, handle this behaviour when you click the new tab button
- Scaffolding for deafult search engine appearing as new tab
- Grab proper search engine information on new tab
- New tab can load default search engine
- Add functionality for new tab options
- Abstraction of handling new tab settings
- Hopefully final abstraction to complete new tab functionality

js/components/main.js

@@ -321,6 +321,7 @@ class Main extends ImmutableComponent {
         }
       }
       let openInForeground = getSetting(settings.SWITCH_TO_NEW_TABS) === true || options.openInForeground
+      // let defaultUrl = newFrameUrl()
       const frameOpts = {
         location: url || config.defaultUrl,
         isPrivate: !!options.isPrivate,

js/lib/appUrlUtil.js

@@ -6,6 +6,9 @@ const Immutable = require('immutable')
 const path = require('path')
 const UrlUtil = require('./urlutil')
 const config = require('../constants/config')
+const getSetting = require('../settings').getSetting
+const settings = require('../constants/settings')
+const searchProviders = require('../data/searchProviders').providers
 
 module.exports.fileUrl = (str) => {
   var pathName = path.resolve(str).replace(/\\/g, '/')
@@ -148,3 +151,30 @@ function getHash (input) {
 }
 
 module.exports.navigatableTypes = ['http:', 'https:', 'about:', 'chrome:', 'chrome-extension:', 'file:', 'view-source:', 'ftp:']
+
+/**
+ * Grabs the url of the new tab
+ */
+ // module.exports.newFrameUrl = function () {
+ //   let newTabMode = getSetting(settings.NEWTAB_MODE)
+ //   let defaultUrl
+ //   switch (newTabMode) {
+ //     case 'newTabPage':
+ //       defaultUrl = 'about:newtab'
+ //       break
+ //     case 'homePage':
+ //       defaultUrl = getSetting(settings.HOMEPAGE)
+ //       break
+ //     case 'defaultSearchEngine':
+ //       let defaultSearchEngine = getSetting(settings.DEFAULT_SEARCH_ENGINE)
+ //       let defaultSearchEngineSettings = searchProviders.filter(engine => {
+ //         return engine.name === defaultSearchEngine
+ //       })
+ //       defaultUrl = defaultSearchEngineSettings[0].base
+ //       break
+ //     default:
+ //       defaultUrl = ''
+ //       break
+ //   }
+ //   return defaultUrl
+ // }

js/stores/windowStore.js

@@ -19,6 +19,7 @@ const currentWindow = require('../../app/renderer/currentWindow')
 const {tabFromFrame} = require('../state/frameStateUtil')
 const {l10nErrorText} = require('../../app/common/lib/httpUtil')
 const {aboutUrls, getSourceAboutUrl, isIntermediateAboutPage, navigatableTypes} = require('../lib/appUrlUtil')
+const searchProviders = require('../data/searchProviders').providers
 const Serializer = require('../dispatcher/serializer')
 
 let windowState = Immutable.fromJS({
@@ -173,6 +174,8 @@ const newFrame = (frameOpts, openInForeground, insertionIndex, nextKey) => {
   if (openInForeground === undefined) {
     openInForeground = true
   }
+
+  // let defaultUrl = newFrameUrl()
   frameOpts.location = frameOpts.location || config.defaultUrl
   if (frameOpts.location && UrlUtil.isURL(frameOpts.location)) {
     frameOpts.location = UrlUtil.getUrlFromInput(frameOpts.location)