Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Unignore cert transparency errors
Browse files Browse the repository at this point in the history
Fix #4159

Auditors: @bridiver

Test Plan: go to https://www.mint.com, verify no cert error appears
  • Loading branch information
diracdeltas committed Sep 28, 2016
1 parent 7516f02 commit 483d24b
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,6 @@ const notifyCertError = (webContents, url, error, cert) => {
app.on('ready', () => {
let sessionStateSaveInterval = null
app.on('certificate-error', (e, webContents, url, error, cert, resourceType, overridable, strictEnforcement, expiredPreviousDecision, cb) => {
// ignore transparency errors for now because we are blocking
// sites that Chrome isn't for some reason (ex: http://www.mint.com)
if (error === 'net::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED') {
e.preventDefault()
cb(true)
return
}

let host = urlParse(url).host
if (host && acceptCertDomains[host] === true) {
// Ignore the cert error
Expand Down

1 comment on commit 483d24b

@bridiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.