workaround to fix about:safebrowsing redirect

fix #8905

Test Plan:
1. safebrowsing test should pass
2. go to downloadme.org. it should redirect to the safebrowsing page and the page should not be blank or have missing text.

app/filtering.js

@@ -144,7 +144,9 @@ function registerForBeforeRequest (session, partition) {
           }))
 
         if (parentResourceName === appConfig.resourceNames.SAFE_BROWSING) {
-          cb({ redirectURL: appUrlUtil.getTargetAboutUrl('about:safebrowsing#' + details.url) })
+          cb({ cancel: true })
+          appActions.loadURLRequested(details.tabId,
+            appUrlUtil.getTargetAboutUrl('about:safebrowsing#' + details.url))
         } else if (details.resourceType === 'image') {
           cb({ redirectURL: transparent1pxGif })
         } else {

js/about/entry.js

@@ -37,8 +37,12 @@ const ipc = window.chrome.ipcRenderer
 let element
 
 ipc.on('language', (e, detail) => {
-  document.l10n.requestLanguages([detail.langCode])
-  document.getElementsByName('availableLanguages')[0].content = detail.languageCodes.join(', ')
+  if (document.l10n) {
+    document.l10n.requestLanguages([detail.langCode])
+    document.getElementsByName('availableLanguages')[0].content = detail.languageCodes.join(', ')
+  } else {
+    console.error('Missing document.l10n object.')
+  }
 })
 ipc.send('request-language')
 

test/bravery-components/safebrowsingTest.js

@@ -0,0 +1,37 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+/* global describe, it, before */
+
+const Brave = require('../lib/brave')
+const {urlInput} = require('../lib/selectors')
+
+describe('safebrowsing interception', function () {
+  function * setup (client) {
+    yield client
+      .waitForBrowserWindow()
+      .waitForVisible(urlInput)
+  }
+
+  Brave.beforeAll(this)
+  before(function * () {
+    this.badUrl = 'http://downloadme.org'
+    this.safebrowsingUrl = `about:safebrowsing#${this.badUrl}`
+    yield setup(this.app.client)
+  })
+
+  it('redirects to safebrowsing URL', function * () {
+    yield this.app.client
+      .tabByIndex(0)
+      .url(this.badUrl)
+      .waitUntil(function () {
+        return this.getText('body').then((val) => {
+          return val.includes('For your safety, Brave has blocked this site')
+        })
+      })
+      .windowByUrl(Brave.browserWindowUrl)
+      .getAttribute(urlInput, 'value').then((value) => {
+        return value === this.safebrowsingUrl
+      })
+  })
+})