Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google Sign In, Nightly Desktop #533

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

ShivanKaul
Copy link
Collaborator

No description provided.

@ShivanKaul ShivanKaul requested a review from a team as a code owner March 6, 2023 16:42
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving & Merging into main so QA can start checking the above on staging before uplifting into production on Nightly.

@kjozwiak kjozwiak merged commit 7e8b8fe into main Mar 7, 2023
@kjozwiak kjozwiak deleted the enable-google-sign-in-on-nightly-desktop branch March 7, 2023 19:29
@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023

Verification PASSED on Win 11 x64 using the following STR/Cases:

Nightly - BraveGoogleSignInPermissionStudy:Enabled

Brave | 1.51.13 Chromium: 111.0.5563.50 (Official Build) nightly (64-bit)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Using the information and STR/Cases mentioned via brave/brave-core#16595, went through the following and ensured that BraveGoogleSignInPermissionStudy:Enabled was being enabled via brave://version and the Allow use of third-party cookies for legacy Google Sign-In permission was appearing on websites mentioned via https://docs.google.com/spreadsheets/d/1323Jfy5l1Iotcvv2hdzW-HTSz7A0698wM9XFbdICVjw.

  • downloaded/installed 1.51.13 Chromium: 111.0.5563.50 and started Brave using the following
  • ensured that BraveGoogleSignInPermissionStudy isn't visible under brave://version and clicking on the Google login via https://www.expensify.com opened another window asking the user to sign-in'
Example Example
disabled1 disabled2
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveGoogleSignInPermissionStudy:Enabled via brave://version
  • ensured that visiting https://www.expensify.com produced a Google login via https://www.expensify.com opened another window asking the user to sign-in' permission modal
  • ensured that there's a new category named Google Sign-In via brave://settings/content
  • ensured that the cookies are being displayed brave://settings/content/googleSignIn
    • Checked Allow and Never and ensured the cookie was being added either Not Allowed or Allowed
Example Example Example Example
enabled1 enabled2 enabled3 enabled4

Release - BraveGoogleSignInPermissionStudy not appearing under brave://version

Brave | 1.48.171 Chromium: 110.0.5481.177 (Official Build) (64-bit)
-- | --
Revision | f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS | Windows 11 Version 22H2 (Build 22621.1265)
  • downloaded/installed 1.48.171 Chromium: 110.0.5481.177 and started Brave using the following
  • ensured that BraveGoogleSignInPermissionStudy isn't visible under brave://version and clicking on the Google login via https://www.expensify.com opened another window asking the user to sign-in'
  • restarted the browser and ensured that BraveGoogleSignInPermissionStudy wasn't visible under brave://version when all the various Griffin studies were pulled/applied

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants